Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Jul 2024 07:23:49 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Zsolt Udvari <uzsolt@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5
Message-ID:  <ZpYgBVxpkjc1w4Rb@FreeBSD.org>
In-Reply-To: <202407131836.46DIaqMZ075082@gitrepo.freebsd.org>
References:  <202407131836.46DIaqMZ075082@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 13, 2024 at 06:36:52PM +0000, Zsolt Udvari wrote:
> commit d6a461ce6716be61682e196cd624903be0557e50
> 
>   games/lolcat: update to 1.5
>   Pet portfmt while I'm here.
> ...
> @@ -19,7 +19,8 @@ CFLAGS+=	-lm
>  
>  CONFLICTS_INSTALL=	filters
>  
> -PLIST_FILES=	bin/censor bin/lolcat
> +PLIST_FILES=	bin/censor \
> +		bin/lolcat

I've seen these one-word-per-line splits before, presumably coming
from this portfmt thingy, and don't quite see the benefit in this
case for example, when words and lines are short.  While I think
I understand the general rationale behind this, it often make the
Makefile actually *less* readable and longer, eating precious
vertical space.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZpYgBVxpkjc1w4Rb>