From owner-svn-src-head@freebsd.org Thu Dec 10 21:10:41 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 670B19D634C; Thu, 10 Dec 2015 21:10:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 4B042184B; Thu, 10 Dec 2015 21:10:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 445ED1B96; Thu, 10 Dec 2015 21:10:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id F3ABC1795D; Thu, 10 Dec 2015 21:10:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 3wIPivtGliO3; Thu, 10 Dec 2015 21:10:38 +0000 (UTC) Subject: Re: svn commit: r291955 - in head: . share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 7C48617955 To: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201512071915.tB7JFqgM052194@repo.freebsd.org> <5669E737.3060105@FreeBSD.org> From: Bryan Drewery Organization: FreeBSD Message-ID: <5669EA4B.8060805@FreeBSD.org> Date: Thu, 10 Dec 2015 13:10:35 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5669E737.3060105@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 21:10:41 -0000 On 12/10/15 12:57 PM, Bryan Drewery wrote: > On 12/7/15 11:15 AM, Ed Maste wrote: >> Author: emaste >> Date: Mon Dec 7 19:15:52 2015 >> New Revision: 291955 >> URL: https://svnweb.freebsd.org/changeset/base/291955 >> >> Log: >> Build and install userland .debug files by default >> >> Debug data files are now built by default with 'make buildworld' and >> installed with 'make installworld'. This facilitates debugging but >> requires more disk space both during the build and for the installed >> world. Debug files may be disabled by setting WITHOUT_DEBUG_FILES=yes >> in src.conf(5). >> >> Reviewed by: bdrewery, eadler, vangyzen >> Relnotes: Yes >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D4018 >> >> Modified: >> head/UPDATING >> head/share/mk/bsd.opts.mk >> >> Modified: head/UPDATING >> ============================================================================== >> --- head/UPDATING Mon Dec 7 19:08:33 2015 (r291954) >> +++ head/UPDATING Mon Dec 7 19:15:52 2015 (r291955) >> @@ -31,6 +31,13 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11 >> disable the most expensive debugging functionality run >> "ln -s 'abort:false,junk:false' /etc/malloc.conf".) >> >> +20151207: >> + Debug data files are now built by default with 'make buildworld' and >> + installed with 'make installworld'. This facilitates debugging but >> + requires more disk space both during the build and for the installed >> + world. Debug files may be disabled by setting WITHOUT_DEBUG_FILES=yes >> + in src.conf(5). >> + >> 20151130: >> r291527 changed the internal interface between the nfsd.ko and >> nfscommon.ko modules. As such, they must both be upgraded to-gether. >> >> Modified: head/share/mk/bsd.opts.mk >> ============================================================================== >> --- head/share/mk/bsd.opts.mk Mon Dec 7 19:08:33 2015 (r291954) >> +++ head/share/mk/bsd.opts.mk Mon Dec 7 19:15:52 2015 (r291955) >> @@ -50,6 +50,7 @@ ____: >> >> __DEFAULT_YES_OPTIONS = \ >> ASSERT_DEBUG \ >> + DEBUG_FILES \ >> DOCCOMPRESS \ >> INCLUDES \ >> INSTALLLIB \ >> @@ -69,7 +70,6 @@ __DEFAULT_NO_OPTIONS = \ >> CCACHE_BUILD \ >> FAST_DEPEND \ >> CTF \ >> - DEBUG_FILES \ >> INSTALL_AS_USER \ >> STALE_STAGED >> >> > > I just noticed. This will cause ports that use /usr/share/mk to now > generate .debug files and have plist errors. > > I'm thinking of the right way to handle this. I want to handle symbols > in ports differently than DEBUG_FILES, so I think I will force > MK_DEBUG_FILES=no for ports builds. I have pending work to complete to > bring symbols support to all of ports, not just those using /usr/share/mk. > Fixed in ports here: https://svnweb.freebsd.org/changeset/ports/403467 textproc/tinyxml is an example port where 'make check-plist' was failing. -- Regards, Bryan Drewery