From owner-svn-src-all@freebsd.org Tue Aug 16 15:32:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C61CBBB9F8; Tue, 16 Aug 2016 15:32:54 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5FAC116F8; Tue, 16 Aug 2016 15:32:54 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp002.me.com by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OC000F00DQWRI00@mr11p00im-asmtp002.me.com>; Tue, 16 Aug 2016 15:32:47 +0000 (GMT) Received: from [192.168.1.4] (c-67-188-225-23.hsd1.ca.comcast.net [67.188.225.23]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OC0007T9DUKUI30@mr11p00im-asmtp002.me.com>; Tue, 16 Aug 2016 15:32:46 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-16_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1608160183 User-Agent: Microsoft-MacOutlook/f.18.0.160709 Date: Tue, 16 Aug 2016 08:32:43 -0700 Subject: Re: svn commit: r304011 - head/libexec/rtld-elf From: Ravi Pokala Sender: "Pokala, Ravi" To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <457F4AE9-A909-44C9-A38B-CD8C28E3068F@panasas.com> Thread-topic: svn commit: r304011 - head/libexec/rtld-elf References: <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1471361567; bh=XexgUX0UrGHzAj/vu5sjK034zo15tnz7eVtJlIvyGH4=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=YmtdskqmKxyprT6s0I331hdktUiPkD8bfaMlqSk3znghpJ/c+mo9jlDY6geW3OARR iCOeu5qFbzEzS1qMR33tKOEHiZAb73pB5loTt5qY761QMrGqF7rUBIYhSd3hMJEQbn BKzZS2gifhwzuUDykeRPWxr1LAaw1wMXZbSqor4/ydtXcBIUtF/lTbJ2Vg6kiJW89G qM3y1BbEWl4y2tMG/81bkVCiKHMsNbPTAnKTpVx04UTLSdzh7X9gy+jMBpOyCqLgGC huqthU1rB39j3o7V9B7miG65V+npKj9YMo5sJG52EcHPZxs54NuvLEncfVIg4O66v9 0evmor50H+rww== X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 15:32:54 -0000 -----Original Message----- From: on behalf of Bryan Drewery Organization: FreeBSD Date: 2016-08-16, Tuesday at 03:30 To: Ngie Cooper , Konstantin Belousov Cc: , , Subject: Re: svn commit: r304011 - head/libexec/rtld-elf >On 8/12/16 7:34 PM, Ngie Cooper wrote: >> >> ... >> >>> Log: >>> Remove all remaining uses of TAILQ_FOREACH_FROM() from rtld-elf. >> >> Why? >> > > It's a somewhat error-prone and dangerous macro. See r302908. I'll grant you "error-prone", but why do you consider it "dangerous"? It's inefficient to walk the whole list when passing NULL as the starting pointer, but I'm not sure what the danger is. And, if it really *is* dangerous, perhaps we should purge the TAILQ_FOREACH_FROM APIs entirely? It looks like rtld-elf was the last (in-tree) user: [freebsd/base/head] rpokala% grep -rl TAILQ_FOREACH_FROM . ./share/man/man3/Makefile ./share/man/man3/queue.3 ./sys/sys/queue.h I confirmed that queue.h just defines the (S)TAILQ_FOREACH_FROM(_SAFE) macros, but doesn't use them internally to define anything else. -Ravi (rpokala@) > -- > Regards, > Bryan Drewery