From owner-cvs-all@FreeBSD.ORG Sun Aug 19 02:26:17 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D04F816A417; Sun, 19 Aug 2007 02:26:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 5F7C913C428; Sun, 19 Aug 2007 02:26:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l7J2NXAO039318; Sat, 18 Aug 2007 20:23:34 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46C7A9A4.5090404@samsco.org> Date: Sat, 18 Aug 2007 20:23:32 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Daniel Eischen References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sat, 18 Aug 2007 20:23:34 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 02:26:17 -0000 Daniel Eischen wrote: > On Sat, 18 Aug 2007, Robert Watson wrote: > >> >> On Sat, 18 Aug 2007, Tijl Coosemans wrote: >> >>> Perhaps it should be stressed in documentation that this syscall is >>> only meant for Wine and to be removed at some point when better >>> solutions become available. I want to test this sigqueue solution >>> some more, because the indirection in signal delivery causes trouble >>> when a thread signals itself. I guess this would have to be >>> special-cased somehow then. >> >> As a general rule, removing system calls is discouraged as it breaks >> backward compatibility allowing newer kernels to run older >> applications, so I think we should avoid adding a system call with the >> intent to remove it in mind at the time it's added :-). While >> thr_kill2() is imperfect from several perspectives, it is certainly a >> minimalist and logical construction that can be easily understood, and >> that's pretty valuable. > > You can say that about a lot of APIs, but that doesn't mean we should add > them. This is a bit of a hack to satisfy one application (Wine) when there > are other (perhaps harder) ways to skin the cat. We certainly don't want > anything else using this API, so I'd advocate removing it. > I'm in strong agreement here. David? Scott