From owner-cvs-all Tue Jan 21 12:31:11 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D59637B401; Tue, 21 Jan 2003 12:31:10 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0852A43F13; Tue, 21 Jan 2003 12:31:10 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 05A42AE2B7; Tue, 21 Jan 2003 12:31:06 -0800 (PST) Date: Tue, 21 Jan 2003 12:31:05 -0800 From: Alfred Perlstein To: Jeffrey Hsu Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20030121203105.GJ33821@elvis.mu.org> References: <200301212020.h0LKKmlk016779@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200301212020.h0LKKmlk016779@repoman.freebsd.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Jeffrey Hsu [030121 12:21] wrote: > hsu 2003/01/21 12:20:48 PST > > Modified files: > sys/kern kern_descrip.c > Log: > Add missing SMP file locks around read-modify-write operations on > the flag field. You shouldn't need these, if the user code races against itself to set flags it shoudn't matter. You can't prevent user races inside the kernel. > Reviewed by: rwatson huh? Sorry, but since when is Robert an SMP guru or filedesc guru? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message