From owner-svn-src-head@freebsd.org Thu May 17 21:41:54 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09EB4EE1425; Thu, 17 May 2018 21:41:54 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AAD5A778D4; Thu, 17 May 2018 21:41:53 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com [209.85.214.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 721CF15065; Thu, 17 May 2018 21:41:53 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f41.google.com with SMTP id n202-v6so10749719ita.1; Thu, 17 May 2018 14:41:53 -0700 (PDT) X-Gm-Message-State: ALKqPwdh9kFsDRYJFOxqkq0GnnJDU9aLEi8RgltEppiW1ayKjx12fKWr IOXeS4SQZZHyGr7J/CZVOdsuvyUowsNylgyweuM= X-Google-Smtp-Source: AB8JxZpu+g6UYC8TXuAybKIpLDEg066p4Dqg9MSie9YIHiaKnf5TPe5GLaNOXLXEqJgPRyFQhuScfi2n5PfV4TOB0G8= X-Received: by 2002:a24:5b54:: with SMTP id g81-v6mr4377599itb.7.1526593312750; Thu, 17 May 2018 14:41:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:3e4a:0:0:0:0:0 with HTTP; Thu, 17 May 2018 14:41:52 -0700 (PDT) In-Reply-To: <148f3ab2-e62f-61e5-9c5f-68c97881a9ee@freebsd.org> References: <201805172104.w4HL4Kag068079@repo.freebsd.org> <148f3ab2-e62f-61e5-9c5f-68c97881a9ee@freebsd.org> From: Matthew Macy Date: Thu, 17 May 2018 14:41:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333765 - head/sys/conf To: Nathan Whitehorn Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 21:41:54 -0000 It's not breaking the build there, but I'd be fine with removing it more generally. -M On Thu, May 17, 2018 at 2:08 PM, Nathan Whitehorn wrote: > > > On 05/17/18 14:04, Matt Macy wrote: >> >> Author: mmacy >> Date: Thu May 17 21:04:19 2018 >> New Revision: 333765 >> URL: https://svnweb.freebsd.org/changeset/base/333765 >> >> Log: >> powerpc: fix LINT build >> netmap currently doesn't build, take it out of LINT to prevent >> hiding regressions in universe >> Reviewed by: jhibbits >> Approved by: sbruno >> >> Modified: >> head/sys/conf/makeLINT.mk >> >> Modified: head/sys/conf/makeLINT.mk >> >> ============================================================================== >> --- head/sys/conf/makeLINT.mk Thu May 17 21:03:36 2018 (r333764) >> +++ head/sys/conf/makeLINT.mk Thu May 17 21:04:19 2018 (r333765) >> @@ -53,6 +53,7 @@ LINT: ${NOTES} ${MAKELINT_SED} >> .if ${TARGET} == "powerpc" >> # cat is available, not sure if cp is? >> cat ${.TARGET} > ${.TARGET}64 >> + echo "nodevice netmap" >> ${.TARGET} >> echo "machine ${TARGET} powerpc" >> ${.TARGET} >> echo "machine ${TARGET} powerpc64" >> ${.TARGET}64 >> .endif >> > > The build error is that it is broken on all 32-bit architectures because of > some integer/pointer type confusion, not just (32-bit) PowerPC. So, if we > aren't fixing it, it at least it should also be removed from ARM, i386, > mips, etc. > -Nathan