From owner-freebsd-fs@FreeBSD.ORG Thu Sep 19 00:11:07 2013 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 62BD9A2B for ; Thu, 19 Sep 2013 00:11:07 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2E4332EAD for ; Thu, 19 Sep 2013 00:11:06 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.16]) by ltcfislmsgpa02.fnfis.com (8.14.5/8.14.5) with ESMTP id r8J0B5Sl003109 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 18 Sep 2013 19:11:05 -0500 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.202]) by LTCFISWMSGHT05.FNFIS.com ([10.132.206.16]) with mapi id 14.02.0309.002; Wed, 18 Sep 2013 19:11:04 -0500 From: "Teske, Devin" To: Rick Macklem Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Topic: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Index: AQHOtMy6gNcXNLXack24f2qWRmdm4w== Date: Thu, 19 Sep 2013 00:11:03 +0000 Message-ID: <13CA24D6AB415D428143D44749F57D720FBD7C18@LTCFISWMSGMB21.FNFIS.com> References: <1480665076.26305077.1379549139533.JavaMail.root@uoguelph.ca> In-Reply-To: <1480665076.26305077.1379549139533.JavaMail.root@uoguelph.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.126] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-09-18_09:2013-09-18,2013-09-18,1970-01-01 signatures=0 Cc: freebsd-fs , "Teske, Devin" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 00:11:07 -0000 On Sep 18, 2013, at 5:05 PM, Rick Macklem wrote: > Devin Teske wrote: >>=20 >>=20 >> Yes, my confusion was... >>=20 >> 1. The PR headers say 8.4-RELEASE-p3 is affected >>=20 >> 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" >>=20 >> Yet... >>=20 >> releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput >> (read: are patched). >>=20 > Did you mean "not patched"? The patched version in head has vput() > and the unpatched versions have VOP_UNLOCK(), if I read the coed correctl= y. >=20 Well, Kirk's fat-finger made me think that VOP_UNLOCK was the patched- state and vput was the unpatched state. (could also be that I'm fighting the flu currently). So everything is copacetic now, except the one outstanding question... Should we not MFC r253998 to stable/8? I'm looking to pull this into our own stable/8 kernel, but would like to do= it by way of svn merge from the stable/8 branch. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.