From owner-freebsd-stable@FreeBSD.ORG Sun Oct 5 08:36:14 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66C2E16A4B3 for ; Sun, 5 Oct 2003 08:36:14 -0700 (PDT) Received: from shimako.yamayuri.org (yumi.yamayuri.org [218.45.22.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8DA243FE5 for ; Sun, 5 Oct 2003 08:36:09 -0700 (PDT) (envelope-from mistral@imasy.or.jp) Received: from shimako.yamayuri.org (localhost [IPv6:3ffe:505:2020:0:203:47ff:fe14:7175])h95Fa4SP002858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 Oct 2003 00:36:04 +0900 (JST) (envelope-from mistral@imasy.or.jp) Received: (from sarumaru@localhost) by shimako.yamayuri.org (8.12.9p2/8.12.9/Submit) id h95Fa07U002857; Mon, 6 Oct 2003 00:36:00 +0900 (JST) (envelope-from sarumaru) From: mistral@imasy.or.jp (Yoshihiko Sarumaru) To: nate@root.org In-Reply-To: Your message of "Fri, 22 Aug 2003 01:08:41 -0700 (PDT)". <20030822010556.M2981@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Mailer: mnews [version 1.22PL5] 2001-02/07(Wed) Date: Mon, 6 Oct 2003 00:36:00 +0900 Message-ID: <031006003600.M0102810@shimako.imasy.or.jp> cc: freebsd-stable@freebsd.org Subject: Re: HEADSUP: USB da(4) quirks disabled for 4.9 and 5.2 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2003 15:36:14 -0000 Hello, This is a more than 1 month old issue but ..., On 22 Aug, nate wrote: > The problem is that a lot of these quirks were added with no documentation > and a cut/paste of both NO_6_BYTE and NO_SYNCHRONIZE_CACHE quirks even > though only one of them was needed. Now that no USB devices should > receive a 6 byte command, that only leaves the NO_SYNCHRONIZE_CACHE > quirks. I am temporarily disabling them to flush out which ones are > REALLY needed. They have been disabled since 2003/07/29 and 2003/08/07 > for -current and -stable, respectively. I have had 0 messages saying that > anything was broken by this. I agree for this point of view. On 22 Aug, nate wrote on the other mail: > > It appears to need it; > > > > umass0: Unsupported UFI command 0x35 > > (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x6, > > scsi status == 0x0 > > Unless that causes an actual problem (i.e. crash, data loss), it is not > necessary to have a quirk for it. There are two kinds of "unsupported" > commands: those that cause the device to hang or crash and those that > successfully reject commands they don't want with the proper return value. > Quirks will only be added for the former. I don't agree for this because this quirk is turned out to have a reason to exist and can be documented. My internal memory stick slot (MSC-U01) always complains above three-line dmesg whenever performing umount, and my console get dirty. That's not good for our health (it doesn't happen until now). So I want to quirks for "Sony", "MS*", "*" will be kept in future releases. I feel this quirk is needed even thougn any data corruption will be occured. -- Yoshihiko Sarumaru mail: mistral@imasy.or.jp web: http://www.imasy.or.jp/~mistral/