Date: Mon, 2 Jul 2007 13:50:16 GMT From: "M. Warner Losh" <imp@bsdimp.com> To: freebsd-ports@FreeBSD.org Subject: Re: bin/11420 [nanobsd] Build failure on RELENG_6 Message-ID: <200707021350.l62DoGMN003352@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/11420; it has been noted by GNATS. From: "M. Warner Losh" <imp@bsdimp.com> To: henrik@brixandersen.dk Cc: freebsd-embedded@freebsd.org, bug-followup@freebsd.org, ru@freebsd.org Subject: Re: bin/11420 [nanobsd] Build failure on RELENG_6 Date: Mon, 02 Jul 2007 07:47:21 -0600 (MDT) In message: <20070702084757.GA8274@tirith.brixandersen.dk> Henrik Brix Andersen <henrik@brixandersen.dk> writes: : On Sun, Jul 01, 2007 at 07:01:35PM -0600, M. Warner Losh wrote: : > In message: <20070701233235.GA875@tirith.brixandersen.dk> : > Henrik Brix Andersen <henrik@brixandersen.dk> writes: : ... : > : [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=114200 : > : > This patch is incorrect. : > : > +.if !defined(NO_INSTALLLIB) : > : > should be : > : > +.if ${MK_INSTALLIB} != "no" : : Oh - thanks for catching this. I guess the same change should be done : in lib/ncurses/ncurses/Makefile, then? I belive so. I've CC'd ru@ to make sure. Warner : Here's an updated patch: : : --- usr.bin/lex/lib/Makefile.orig 2007-07-02 01:06:20.000000000 +0200 : +++ usr.bin/lex/lib/Makefile 2007-07-02 10:41:47.000000000 +0200 : @@ -6,8 +6,10 @@ : SRCS= libmain.c libyywrap.c : NO_PIC= : : +.if ${MK_INSTALLLIB} != "no" : LINKS= ${LIBDIR}/libln.a ${LIBDIR}/libl.a : LINKS+= ${LIBDIR}/libln.a ${LIBDIR}/libfl.a : +.endif : : .if ${MK_PROFILE} != "no" : LINKS+= ${LIBDIR}/libln_p.a ${LIBDIR}/libl_p.a : : : And for good meassure - a patch for lib/ncurses/ncurses/Makefile: : : --- lib/ncurses/ncurses/Makefile.orig 2007-07-02 10:43:17.000000000 +0200 : +++ lib/ncurses/ncurses/Makefile 2007-07-02 10:44:14.000000000 +0200 : @@ -280,7 +280,7 @@ : INCSLINKS= curses.h ${INCLUDEDIR}/ncurses.h : .endif : : -.if !defined(NO_INSTALLLIB) : +.if ${MK_INSTALLLIB} != "no" : SYMLINKS+= libncurses${LIB_SUFFIX}.a ${LIBDIR}/libcurses${LIB_SUFFIX}.a : SYMLINKS+= libncurses${LIB_SUFFIX}.a ${LIBDIR}/libtermcap${LIB_SUFFIX}.a : SYMLINKS+= libncurses${LIB_SUFFIX}.a ${LIBDIR}/libtermlib${LIB_SUFFIX}.a : : : -- : Henrik Brix Andersen <henrik@brixandersen.dk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707021350.l62DoGMN003352>