From owner-freebsd-hackers@FreeBSD.ORG Tue Aug 5 03:35:33 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6A9337B401 for ; Tue, 5 Aug 2003 03:35:33 -0700 (PDT) Received: from sweeper.openet-telecom.com (mail.openet-telecom.com [62.17.151.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9F9143F85 for ; Tue, 5 Aug 2003 03:35:32 -0700 (PDT) (envelope-from peter.edwards@openet-telecom.com) Received: from mail.openet-telecom.com (unverified) by sweeper.openet-telecom.com ; Tue, 5 Aug 2003 11:38:40 +0100 Received: from [10.0.0.40] (10.0.0.40) by mail.openet-telecom.com (NPlex 6.5.027) id 3F268E0000003CD2; Tue, 5 Aug 2003 11:34:01 +0100 From: Peter Edwards To: Simon Barner In-Reply-To: <20030805100558.GA15128@zi025.glhnet.mhn.de> References: <20030730224505.GD531@zi025.glhnet.mhn.de> <1060076564.57234.11.camel@rocklobster.openet-telecom.lan> <20030805100558.GA15128@zi025.glhnet.mhn.de> Content-Type: text/plain Organization: Openet Telecom Message-Id: <1060079419.57234.35.camel@rocklobster.openet-telecom.lan> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.0 Date: 05 Aug 2003 11:30:20 +0100 Content-Transfer-Encoding: 7bit cc: freebsd-hackers@freebsd.org Subject: Re: getfsent(3) and spaces in fstab X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2003 10:35:34 -0000 On Tue, 2003-08-05 at 11:05, Simon Barner wrote: > Hi, > > > Check PR 37569: This bugged the hell out of me also, so I created a > > patch to allow enclosing the device name in quotes. The PR was logged > > over a year ago: I can't remember the details, but the source has been > > sitting silently in my tree and working since then. Whatever way the > > problem is resolved, can someone close the PR? > > I can't believe it... I have searched the PR database, Google, etc. for > existing solutions to this problem, but I did not find yours. I also > considered using quotes, but since you need escape-sequences to encode > quotes in your solution, too, the approach using '\ ', '\', '\\' is > simpler and cleaner IMHO. > > Simon I find the "quotes" approach produces more readable (and manageable) fstabs, but I don't care about that sufficiently to argue further :-). Anything that addresses the problem and can close the PR will suit me!