From owner-freebsd-ports@FreeBSD.ORG  Mon Mar 15 02:54:44 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ECBF116A4CE
	for <ports@FreeBSD.org>; Mon, 15 Mar 2004 02:54:44 -0800 (PST)
Received: from postman.arcor.de (newsread1.arcor-online.net [151.189.0.146])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4A1CF43D2D
	for <ports@FreeBSD.org>; Mon, 15 Mar 2004 02:54:44 -0800 (PST)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from fillmore.dyndns.org (port-212-202-51-138.reverse.qsc.de
	[212.202.51.138])	(authenticated bits=0)i2FAsgck003853
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Mon, 15 Mar 2004 11:54:42 +0100 (MET)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD)
	id 1B2pjz-0009JH-Q0; Mon, 15 Mar 2004 11:54:39 +0100
Message-ID: <40558B72.3090409@fillmore-labs.com>
Date: Mon, 15 Mar 2004 11:54:42 +0100
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <20040315103649.GA13718@xor.obsecurity.org>
In-Reply-To: <20040315103649.GA13718@xor.obsecurity.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: ports@FreeBSD.org
Subject: Re: INDEX user-friendliness and SMP speed-up patch
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2004 10:54:45 -0000

Kris Kennaway wrote:

> +	if [ "${INDEX_PRISTINE}" != "" ]; then \
> +		export LOCALBASE=/nonexistentlocal; \
> +		export X11BASE=/nonexistentx; \
> +	fi; \

Will you set DEFAULT_OPTIONS=yes here (for PR 64233), or should I test for 
INDEX_PRISTINE?

> +	cat $${tmpdir}/${INDEXFILE}.desc.* | perl ${.CURDIR}/Tools/make_index | \
> +		sed -e 's/  */ /g' -e 's/|  */|/g' -e 's/  *|/|/g' -e "s,$${LOCALBASE},/usr/local," \
> +			-e "s,$${X11BASE},/usr/X11R6," -e 's./.
.g' | \

Is "s,$${LOCALBASE},/usr/local," "s,$${X11BASE},/usr/X11R6," appropriate
if INDEX_PRISTINE is not defined?

> +.if defined(BUILDING_INDEX)
> +describe: ${SUBDIR:S/^/describe./}
> +
> +.for i in ${SUBDIR}
> +describe.$i:
> +	@${MAKE} -B ${i:S/^/_/:S/$/.describe/} > ${INDEX_TMPDIR}/${INDEXFILE}.desc.${i}
> +.endfor
> +.else
>  describe: ${SUBDIR:S/^/_/:S/$/.describe/}
> +.endif

I always wondered why we don't have

.PHONY describe

and

.PHONY describe.$i

here. Any reasons for that?