From owner-cvs-all  Thu Mar  7  4:25:25 2002
Delivered-To: cvs-all@freebsd.org
Received: from mail.nsu.ru (mx.nsu.ru [193.124.215.71])
	by hub.freebsd.org (Postfix) with ESMTP
	id 02D9C37B416; Thu,  7 Mar 2002 04:25:00 -0800 (PST)
Received: from regency.nsu.ru ([193.124.210.26] helo=cytherea.weblab.nsu.ru)
	by mail.nsu.ru with esmtp (Exim 3.20 #1)
	id 16iwwM-0003vY-00; Thu, 07 Mar 2002 18:24:10 +0600
Received: (from danfe@localhost)
	by cytherea.weblab.nsu.ru (8.11.6/8.11.6) id g27CQeW91646;
	Thu, 7 Mar 2002 18:26:40 +0600 (NOVT)
	(envelope-from danfe)
Date: Thu, 7 Mar 2002 18:26:40 +0600
From: Alexey Dokuchaev <danfe@cytherea.weblab.nsu.ru>
To: "David O'Brien" <obrien@freebsd.org>
Cc: Mark Murray <markm@freebsd.org>, cvs-committers@freebsd.org,
	cvs-all@freebsd.org
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
Message-ID: <20020307182640.A87748@cytherea.weblab.nsu.ru>
References: <20020307033328.A64158@dragon.nuxi.com> <200203071210.g27CA8RV010023@grimreaper.grondar.org> <20020307041457.A66608@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20020307041457.A66608@dragon.nuxi.com>; from obrien@freebsd.org on Thu, Mar 07, 2002 at 04:14:57AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Mar 07, 2002 at 04:14:57AM -0800, David O'Brien wrote:
> On Thu, Mar 07, 2002 at 12:10:08PM +0000, Mark Murray wrote:
> > > On Thu, Mar 07, 2002 at 11:27:02AM +0000, Mark Murray wrote:
> > > > > -       if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+")))
> > > > > +       fd = mkstemp(tmpname);
> > > > > +       fp = fdopen(fd, "r+");
> > > > > +       if (fd == -1 || !fp)
> > > > > 
> > > > > Why did you need to do such code restructuring?
> > > > 
> > > > "Assignment statement in conditional". I also happens to be more readable.
> > > 
> > > Feh.  Please back this type of changes out.  The logic is not the same
> > > before and after.
> > 
> > Here is the clearer fix:
> 
> The original code was cleaner.  Since we are getting into HO's; we should
> stick with the original version.

I fully agree.

./danfe

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message