From owner-freebsd-current@FreeBSD.ORG Wed Jan 2 12:05:04 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCECD766 for ; Wed, 2 Jan 2013 12:05:04 +0000 (UTC) (envelope-from se@freebsd.org) Received: from nm20-vm0.bullet.mail.ird.yahoo.com (nm20-vm0.bullet.mail.ird.yahoo.com [77.238.189.221]) by mx1.freebsd.org (Postfix) with ESMTP id CE99C8FC08 for ; Wed, 2 Jan 2013 12:05:03 +0000 (UTC) Received: from [77.238.189.232] by nm20.bullet.mail.ird.yahoo.com with NNFMP; 02 Jan 2013 12:04:57 -0000 Received: from [217.146.189.66] by tm13.bullet.mail.ird.yahoo.com with NNFMP; 02 Jan 2013 12:04:57 -0000 Received: from [127.0.0.1] by smtp146.mail.ird.yahoo.com with NNFMP; 02 Jan 2013 12:04:57 -0000 X-Yahoo-Newman-Id: 169403.19021.bm@smtp146.mail.ird.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: AhYtvA4VM1kzJuuwc7yVOfAykmPQ7plT.8YLFrPwL340.it a06i1mMihjaANnvS2p5H1LDvV6zTd175o4WZKBU2gqQFyUAuPlL4kNYPlG9w sVtf5yhj1ZUtbHDm1.3d58A0dNQXa4vO4iDxs8bCXiVF8GsLZSL9a8_26kpR nr5NrNEohb.1XBulAxQG7pXsp6Yu8Ec3TvNUpEagtiU1Izd1RSuiaTt076rm ndb6YoPg_4G11CPze.yfb0Ix9TEKXmd65kUD7nKiwoopqI2.2t2k_iPgvcxV qsJdFrD_SNwtBDJB.Pq5s6n5wRMQcn.dB7BQ8Gr4RLOE17aLm5XT8C_JkzK8 bSWj0cZDc90EPlmpN.yNos3GXBWosgzcLw3FylUKpHGbuNudUzVUA50vhqyb O8vJ_opUPPSwaXzYbNVkml0O7BvVx5DqpGSFcxvnseKU_ X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. Received: from [192.168.119.11] (se@87.158.26.233 with plain) by smtp146.mail.ird.yahoo.com with SMTP; 02 Jan 2013 04:04:57 -0800 PST Message-ID: <50E42264.4010609@freebsd.org> Date: Wed, 02 Jan 2013 13:04:52 +0100 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: freebsd-current@freebsd.org, nwhitehorn@freebsd.org Subject: installworld failure due to cross-device links X-Enigmail-Version: 1.4.6 Content-Type: multipart/mixed; boundary="------------020704000602010000070205" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2013 12:05:04 -0000 This is a multi-part message in MIME format. --------------020704000602010000070205 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit I'd be interested in the general policy on LINKS vs. SYMLINKS between directories that might end up on different file systems. There seems to be an assumption that system directories in /usr (e.g. /usr/bin, /usr/sbin, /usr/libexec) are on the same file system, but I do not think that this assumption is documented. I'm using a ZFS only installation of -CURRENT and have separate file systems for several of the directories in / and /usr, that usually share a file system (e.g. /bin, /sbin, but also /usr/bin/, /usr/sbin and /usr/libexec are independent file systems). An older case is the link from /usr/bin/chgrp to /usr/sbin/chown (see usr.sbin/chown/Makefile), which is easily fixed by using a SMYLINK instead of a LINK. And now there is usr.sbin/bsdinstall/partedit/Makefile, which as of r244859 creates a link from /usr/libexec/bsdinstall to /usr/sbin/sade. This breaks with /usr/bin and /usr/sbin on different file systems, while it should not according to the commit message: ---------------------------------------------------------------------- r244859 | nwhitehorn | 2012-12-30 15:35:00 +0100 (Sun, 30 Dec 2012) | 7 lines Replace sade the extracted piece of sysinstall with sade the extracted piece of bsdinstall (although this time with a symlink instead of duplicated source code). Discussed on: freebsd-geom MFC after: 3 months ---------------------------------------------------------------------- The SYMLINK mentioned in the commit message is a LINK to a different directory, which might be on a different file system, actually. This should be fixed by the attached patch, to remove the implied assumption and to make the Makefile match the commit message. Regards, STefan --------------020704000602010000070205 Content-Type: text/plain; charset=windows-1252; name="partedit.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="partedit.patch" Index: Makefile =================================================================== --- Makefile (revision 244957) +++ Makefile (working copy) @@ -2,7 +2,8 @@ BINDIR= /usr/libexec/bsdinstall PROG= partedit -LINKS= ${BINDIR}/partedit ${BINDIR}/autopart ${BINDIR}/partedit /usr/sbin/sade +LINKS= ${BINDIR}/partedit ${BINDIR}/autopart ${BINDIR}/partedit +SYMLINKS= /usr/sbin/sade LDADD= -lgeom -lncursesw -lutil -ldialog -lm PARTEDIT_ARCH= ${MACHINE} --------------020704000602010000070205--