From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 2 16:50:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D1EF106564A for ; Fri, 2 Jul 2010 16:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F05518FC0A for ; Fri, 2 Jul 2010 16:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o62Go3p2069133 for ; Fri, 2 Jul 2010 16:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o62Go3Lb069132; Fri, 2 Jul 2010 16:50:03 GMT (envelope-from gnats) Date: Fri, 2 Jul 2010 16:50:03 GMT Message-Id: <201007021650.o62Go3Lb069132@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Norikatsu Shigemura Cc: Subject: Re: bin/148296: [zfs] [loader] Very slow probe in /usr/src/sys/boot/zfs/zfs.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Norikatsu Shigemura List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2010 16:50:04 -0000 The following reply was made to PR bin/148296; it has been noted by GNATS. From: Norikatsu Shigemura To: Jimmy Olgeni Cc: FreeBSD-gnats-submit@freebsd.org, rnoland@freebsd.org Subject: Re: bin/148296: [zfs] [loader] Very slow probe in /usr/src/sys/boot/zfs/zfs.c Date: Sat, 3 Jul 2010 01:40:19 +0900 Hi olgeni. On Thu, 1 Jul 2010 16:09:36 GMT Jimmy Olgeni wrote: > >Number: 148296 > >Category: bin > >Synopsis: [zfs] [loader] Very slow probe in /usr/src/sys/boot/zfs/zfs.c > Since we are looking for boot partitions, I think it should be safe > to assume that there are no empty partitions before them. > I moved slice probing into a separate loop to avoid any issues with > fallback code. > With the attached patch my 8.1-RC1 zfs-only server got back its old > boot time. That's good news! I confirmed your patch on my 9-current - GPT only environment. Now I'm testing on my MBR environment (now make world-ing). -- Norikatsu Shigemura