Date: Tue, 20 Nov 2018 11:15:10 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: Mathieu Arnold <mat@FreeBSD.org>, ports@FreeBSD.org
Subject: Re: r479405 ("PLIST_SUB must be appended to") missing lang/gcc8 ?
Message-ID: <20181120101510.xjyu5qizqz34fd2n@atuin.in.mat.cc>
In-Reply-To: <alpine.LSU.2.21.1811180617300.7079@anthias.pfeifer.com>
References: <alpine.LSU.2.21.1811180617300.7079@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--x7cckp4iclqqmhou
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
On Sun, Nov 18, 2018 at 07:21:08AM -0700, Gerald Pfeifer wrote:
> Hi Mat,
>=20
> I noticed that=20
>=20
> r479405 | mat | 2018-09-10 13:11:23 +0000 (Mo., 10 Sep. 2018) | 9 lines
>=20
> After an include, PLIST_SUB must be appended to, not overwritten.
>=20
> If it is overwritten, many values will be clobbered, and
> pain will ensue.
>=20
> PR: 230864
> Submitted by: mat
> exp-runs by: antoine
>=20
> did not cover lang/gcc8 (nor lang/gcc9-devel).
>=20
>=20
> OTOH `diff lang/gcc7/Makefile lang/gcc8` shows this as nearly the only
> difference between the two versions, short of version-specific lines.
>=20
>=20
> Does this look like an small omission I should address? I have this=20
> locally and tested, but figured I'd double check before committing.
Yes, it should be fixed, thanks for finding It. I'm not sure why I did
not picked those two ports at the time, maybe I was working on the patch
for too long and missed the ports being added.
> Gerald
>=20
>=20
> Index: lang/gcc8/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- lang/gcc8/Makefile (revision 485224)
> +++ lang/gcc8/Makefile (working copy)
> @@ -95,7 +95,7 @@
> --with-system-zlib
> MAKE_ARGS+=3D MAKEINFOFLAGS=3D"--no-split"
> USE_LDCONFIG=3D ${TARGLIB}
> -PLIST_SUB=3D GCC_VERSION=3D${GCC_VERSION} \
> +PLIST_SUB+=3D GCC_VERSION=3D${GCC_VERSION} \
> GNU_HOST=3D${CONFIGURE_TARGET} \
> SUFFIX=3D${SUFFIX}
> INFO=3D gcc${SUFFIX}/cpp \
> Index: lang/gcc9-devel/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- lang/gcc9-devel/Makefile (revision 485224)
> +++ lang/gcc9-devel/Makefile (working copy)
> @@ -97,7 +97,7 @@
> --with-system-zlib
> MAKE_ARGS+=3D MAKEINFOFLAGS=3D"--no-split"
> USE_LDCONFIG=3D ${TARGLIB}
> -PLIST_SUB=3D GCC_VERSION=3D${GCC_VERSION} \
> +PLIST_SUB+=3D GCC_VERSION=3D${GCC_VERSION} \
> GNU_HOST=3D${CONFIGURE_TARGET} \
> SUFFIX=3D${SUFFIX}
> INFO=3D gcc${SUFFIX}/cpp \
>=20
--=20
Mathieu Arnold
--x7cckp4iclqqmhou
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvz3q5fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zki2xQ/9ECWTVKeaHLJBe0/xctYU8Vp/6OyZv05BYmBXEV8i9BtReWzT1myGbI/k
JBFlQMEAFF5JxRB+PgEyn1fVjph4iyjTG1r/FnPuamgva++YYu6pbhRxsnGiHxRV
2Zc+yNHD9z41tvwfnzW3Ol+h2gIT4YB8bhgKYfNf6qP0VPAvBmbzPDhEAeSXI7e6
1bQZh0cw6PVqcL3giTRsKsAtH4XZqajQmgjqloDVkPGPE7mvQK6pNGPmIpM41QFt
Ef6jUIEhbKqDe/dFgryjuOG0VrVbyFeUD9WJqYf0DS77aGTkM36n8juOJKWnCLek
nGWwdaCgrYN23KKMmdKcCCij81gaIWfsDOuKNnE1LcbhpnGy0dPy+juYXrxiDNpT
HVjxbtrUS392cTLaVB3NxXyvyF1thNh0Mcaipz0pfNmPLt+8PTkvqIdu8lttaKP5
+rao4FKJA6CRm2kjqnV2KIc4JxbU2nwnApvXQ9YVA1eLBHNWJAsBW25XPgJ6FtNd
6s2fU/1OBi5T8hZEIoShs62kWt79GcSFk2TPDbhClLZhuspMsqTmLuDXKmSt65Ay
eA9NIZyDDzRpFCc+PE37awoidXjd41lbgNV78+povDIx7F9nvB7xIbCvKJ5D7EBA
UpNBOvkqeIZzuvSKC+VnZl1J7Q0bIRHi+dAbQ6QTtaeEpubtgF8=
=t8I0
-----END PGP SIGNATURE-----
--x7cckp4iclqqmhou--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181120101510.xjyu5qizqz34fd2n>