From owner-svn-src-head@FreeBSD.ORG Fri Feb 7 18:27:05 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1E99EFF0 for ; Fri, 7 Feb 2014 18:27:05 +0000 (UTC) Received: from mail-qc0-x236.google.com (mail-qc0-x236.google.com [IPv6:2607:f8b0:400d:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C69FA1AF6 for ; Fri, 7 Feb 2014 18:27:04 +0000 (UTC) Received: by mail-qc0-f182.google.com with SMTP id c9so6642435qcz.13 for ; Fri, 07 Feb 2014 10:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=PmRqVeKIkOLIehdHYawpEqGqa0PIBj70TcglvXIyIvA=; b=KPC0XnA9yiS70gBWZPO9M7Bb5HtMLTVtuu7NCYV0tlio2kKVv6e4TjN96N/ucBGZFA gLjXnI4cMlIMRIIXolq5vdz0UrixMehrac9lhCXrCo7Kdk+uGcPrUHZb5DyxdiVWv2yC ItXGbnTfvmbQ4AJq5DUgDDLDXVSL8Od+x27RQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=PmRqVeKIkOLIehdHYawpEqGqa0PIBj70TcglvXIyIvA=; b=ZzkXvhMuZJAu6iCcG+ldIWQ2xpUb5ZoJ/SCxkEhgBGqtdLTCourmBEotY0LXcHebkS 8XNomwKaLNZ7ZU5bGgJNHS5F/2WyVeCV23AL/XHZF5xYZj0kzy3qvwsrq5pw6DlbDI4G 4dk3kK0ipMoIioty3w0RafQxO70cETkgNgYuk4zplDjboO6LEh4Xj0sn/rJ0zOmlDp7+ +ISrFKk29OkucpCwdigyF9EcHbt6fJoz0Opsb+bna1RwgGYUlATkKSsCn/aJzYgV5PUl fmhazHZ6oxtJws2ei1jpAEPjORf51V3PU/U4kHQK0KyCObaetKCmBS0hXIIQuoX7jd2Z hoBg== X-Gm-Message-State: ALoCoQlrVNkBZjl1RjL/nz0FqmTdrgGpoJxtgUuSRHEiXFqGviU1845wbm5ehU0NxD4F/NBH55mV X-Received: by 10.224.127.202 with SMTP id h10mr25019395qas.23.1391797623541; Fri, 07 Feb 2014 10:27:03 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.30.229 with HTTP; Fri, 7 Feb 2014 10:26:33 -0800 (PST) In-Reply-To: References: <201402071810.s17IAZtx043815@svn.freebsd.org> From: Eitan Adler Date: Fri, 7 Feb 2014 13:26:33 -0500 X-Google-Sender-Auth: giec9B4qyVLH93TgSwHLIL_xjj8 Message-ID: Subject: Re: svn commit: r261604 - head/contrib/libc++/include To: Alan Somers Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2014 18:27:05 -0000 On Fri, Feb 7, 2014 at 1:14 PM, Alan Somers wrote: > On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler wrote: >> Author: eadler >> Date: Fri Feb 7 18:10:34 2014 >> New Revision: 261604 >> URL: http://svnweb.freebsd.org/changeset/base/261604 >> >> Log: >> HEAD is not buildable for the past day. Commit a 'quick fix' in order to permit >> buildworld to complete. >> >> Reviewed by: theraven >> >> Modified: >> head/contrib/libc++/include/locale > > Are you sure that this will work on all architectures? I didn't run 'make universe' but I think it should work. This was committed this after waiting a day for a real fix to be done. I had / have other work which I needed to get done and did not analize this code in detail. > It implicitly > assumes that ptrdiff_t is the same as long. It assumes that ptrdiff_t is signed and sizeof (ptrdiff_t) <= sizeof(long). Please feel free to modify my hack or otherwise fix the code. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams