From owner-cvs-all  Sat Aug 26 12:29: 9 2000
Delivered-To: cvs-all@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id C80C837B42C; Sat, 26 Aug 2000 12:29:05 -0700 (PDT)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id NAA82030;
	Sat, 26 Aug 2000 13:29:04 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id NAA80920; Sat, 26 Aug 2000 13:28:55 -0600 (MDT)
Message-Id: <200008261928.NAA80920@harmony.village.org>
To: Doug White <dwhite@resnet.uoregon.edu>
Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c 
Cc: Marcel Moolenaar <marcel@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-reply-to: Your message of "Sat, 26 Aug 2000 12:11:59 PDT."
		<Pine.BSF.4.21.0008261211250.40564-100000@resnet.uoregon.edu> 
References: <Pine.BSF.4.21.0008261211250.40564-100000@resnet.uoregon.edu>  
Date: Sat, 26 Aug 2000 13:28:55 -0600
From: Warner Losh <imp@village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <Pine.BSF.4.21.0008261211250.40564-100000@resnet.uoregon.edu> Doug White writes:
: Um, isn't this a no-no?  You're not supposed to re-style existing files;
: you generated a 700-line diff for no functional change.

Generally it is a nono, but if there's a good reason for it, then it
could be OK.  since Marcel has done a lot with the linuxulator in
FreeBSD I think it may come close to "good reason" threshold.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message