Date: Wed, 17 Feb 2021 01:36:47 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 253303] sysutils/memtest86+: remove dependency on gcc48 Message-ID: <bug-253303-7788-vSJ5Np8kFk@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253303-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-253303-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253303 --- Comment #7 from commit-hook@FreeBSD.org --- A commit references this bug: Author: kevans Date: Wed Feb 17 01:36:15 UTC 2021 New revision: 565472 URL: https://svnweb.freebsd.org/changeset/ports/565472 Log: sysutils/memtest86+: remove dependency on gcc48 This is one of three ports still explicitly dependent on lang/gcc48. The problems that were preventing the upgrade were as follows: - The __OUT*/__IN* macros in io.h were declaring the produced functions as extern, yielding multiple "definitions." They're inline asm, so just gi= ve them static linkage. - reboot was declared inline with non-static linkage, thus leaving it in a weird state where it wasn't visible within the same CU or another CU. Drop the inline for now; if it really needs to be inlined, it can be moved into a header and declared `static inline`. I made these changes, then discovered there's a 5.31b that's still in testing. I checked the archive for that and was delighted to discover the= se changes had already actually been made there, too, so let's consider this= a backport. PR: 253303 Approved by: avg (maintainer) MFH: 2021Q1 Changes: head/sysutils/memtest86+/Makefile head/sysutils/memtest86+/files/patch-io.h head/sysutils/memtest86+/files/patch-lib.c --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253303-7788-vSJ5Np8kFk>