From owner-svn-src-all@FreeBSD.ORG Fri Dec 12 20:35:25 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 96B8A62F; Fri, 12 Dec 2014 20:35:25 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CA52E8E; Fri, 12 Dec 2014 20:35:24 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id sBCKZHmX055521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 12 Dec 2014 12:35:17 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id sBCKZHoS055520; Fri, 12 Dec 2014 12:35:17 -0800 (PST) (envelope-from jmg) Date: Fri, 12 Dec 2014 12:35:17 -0800 From: John-Mark Gurney To: John Baldwin Subject: Re: svn commit: r275732 - in head: etc/mtree share/man/man4 share/man/man7 share/man/man9 sys/conf sys/crypto/aesni sys/crypto/via sys/geom/eli sys/libkern sys/mips/rmi/dev/sec sys/modules/aesni sys/mo... Message-ID: <20141212203517.GE25139@funkthat.com> References: <201412121956.sBCJucpj048475@svn.freebsd.org> <1533978.vC7tcjiHLN@ralph.baldwin.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533978.vC7tcjiHLN@ralph.baldwin.cx> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 12 Dec 2014 12:35:17 -0800 (PST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Dec 2014 20:35:25 -0000 John Baldwin wrote this message on Fri, Dec 12, 2014 at 15:23 -0500: > On Friday, December 12, 2014 07:56:38 PM John-Mark Gurney wrote: > > Author: jmg > > Date: Fri Dec 12 19:56:36 2014 > > New Revision: 275732 > > URL: https://svnweb.freebsd.org/changeset/base/275732 > > > > Log: > > Add some new modes to OpenCrypto. These modes are AES-ICM (can be used > > for counter mode), and AES-GCM. Both of these modes have been added to > > the aesni module. > > > > Obtained from: p4: //depot/projects/opencrypto > > Relnotes: yes > > Sponsored by: FreeBSD Foundation > > Sponsored by: NetGate > > No reviewers? (I thought FF projects required a reviewer?) Were you not able > to get other folks to review this when you asked? > > With crypto involved, it would seem like a good idea to have run this by > secteam if you hadn't. (If you did, something like 'Silence from: secteam' > in the commit log would have let us know you tried and didn't get any > feedback). Sorry, I did get reviewers for specific parts of the project... But they were third party reviewers... Watson Ladd did the software AES review, and Mike Hamburg did the AES-NI review. Also, I posted an earlier version of this patch to -security and -current over a month ago, and didn't get any significant responses... Sorry for not including that in the commit. Want me to do a null commit to record it? or? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."