From owner-svn-ports-all@freebsd.org  Tue Apr 18 18:16:25 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7ABC9D44646
 for <svn-ports-all@mailman.ysv.freebsd.org>;
 Tue, 18 Apr 2017 18:16:25 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0D5C7ED5
 for <svn-ports-all@freebsd.org>; Tue, 18 Apr 2017 18:16:24 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 1edb9b91-2463-11e7-b96e-2378c10e3beb
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id 1edb9b91-2463-11e7-b96e-2378c10e3beb;
 Tue, 18 Apr 2017 18:16:21 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id v3IIGGis009227;
 Tue, 18 Apr 2017 12:16:16 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1492539376.96207.31.camel@freebsd.org>
Subject: Re: svn commit: r438739 - head/editors/emacs-devel
From: Ian Lepore <ian@freebsd.org>
To: Mathieu Arnold <mat@FreeBSD.org>, Joseph Mingrone <jrm@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Date: Tue, 18 Apr 2017 12:16:16 -0600
In-Reply-To: <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org>
References: <201704171817.v3HIHrKH039517@repo.freebsd.org>
 <9c424b79-d270-6d5f-c625-3de54e721888@FreeBSD.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Apr 2017 18:16:25 -0000

On Tue, 2017-04-18 at 18:30 +0200, Mathieu Arnold wrote:
> Le 17/04/2017 à 20:17, Joseph Mingrone a écrit :
> > 
> >   Also add MAKE_JOBS_UNSAFE=yes.
> >   
> This bit of the commit message is useless.  The fact that you added
> MAKE_JOBS_UNSAFE can be seen clearly in the commit diff below.  What
> cannot be seen and is now lost is why you are adding it.
> Does it have problems ordering targets ? Does it try to use a file
> before it is generated... ?
> People regularly go and try to fix these kind of things. If you do not
> explain they why, it is lost, and they have no idea where to begin their
> search.

The info doesn't have to be lost forever, it's not at all hard to
revert the change then re-commit with the proper message.

-- Ian