From owner-cvs-all@FreeBSD.ORG  Wed Jul  2 21:16:05 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 4CE83106567B; Wed,  2 Jul 2008 21:16:05 +0000 (UTC)
Date: Wed, 2 Jul 2008 21:16:05 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Rong-En Fan <rafan@FreeBSD.org>
Message-ID: <20080702211605.GA50200@FreeBSD.org>
References: <200807021457.m62EvudQ046920@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200807021457.m62EvudQ046920@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/lynx Makefile pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jul 2008 21:16:05 -0000

On Wed, Jul 02, 2008 at 02:57:56PM +0000, Rong-En Fan wrote:
> rafan       2008-07-02 14:57:56 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/lynx             Makefile pkg-plist 
>   Log:
>   - Use ncursesw if available
>   - Use gzip for documents
>   - OPTIONS'ify
>   - Bump PORTREVISION

I have a couple of questions:

- Is CONFIGURE_TARGET really necessary here? Is yes, could you elaborate
  on why whould it be?
- Exatra parameter --enable-nested-tables was added to CONFIGURE_ARGS,
  but commit log does not mention it.  What changes does it bring?
- In OPTIONS, "Colors support" does not look very descriptive to me
- Again in OPTIONS, "IPV6 support" should probably be speeled as IPv6
- OPTIONS are badly indented
- .if defined(WITH_IPV6) && ! defined(NO_INET6) -- superfluous space
  after !
- ENABLE_DEFAULT_COLORS should probably be dropped altogether (with
  corresponding UPDARING note): we should not encourage non-standard
  knobs (i.e. not starting with WITH/WITHOUT) in most cases

This is just what cathes the eye, it's not thorough review.

./danfe