From nobody Wed Oct 18 12:30:41 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S9VYr5cfKz4wxyB; Wed, 18 Oct 2023 12:30:40 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S9VYr57Xsz4b08; Wed, 18 Oct 2023 12:30:40 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697632240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t7LUO13cI7H7bPbnkXhsWsVeYwPrjJ1PCNXk0Ix/MJg=; b=UsVcRJGMMQ01agORuA3R5VgsH6o//VU4RJrgLt/PxZiAJ4V8DvmlSVxFD7XHW1SavRqsdj gfExpxo8ZA2GJSbEgHWhmlcABEiOTZ68oXUy/pEwsjMHspfk3fOgZBkgLB4YojtE8mqj1/ zD0gDnpToK42YPVwnXn9hae9S5+sLBwc0lX/U0AnJJLaAZlKKkxK3q07MOXu9J7T0UCgAY 7kj/MoDPLomlL0MjjdMfq3jhLGTzp8aBBMoszRWM6qLYJRbhjDL1pC8tuUR2Y2wkepKfxP /R+9P813ycCWte6oZOxwpedKs83B12ftakFBt0pLysy0SzfTtQ4UuZSrkwpuww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697632240; a=rsa-sha256; cv=none; b=uQ+LEHFF2lLI19/X47g958VuQkD52aEczLAh8hr/OgmuwxfndiBp3ihAW5GajfAswLYqZg 31R6gwG6VdPN57tQgg+6zChUawSNT+jBYpcsab7nf0T/XYUYF4CsCbkVZf83QYrfSv+CHr JyrwPZ6EQbs0zsaPXjXOp8GtzqMPyX6BliOnXM82dXzMK5YOa1lubgOCsD7jtQjvtiUAz6 fP/Y0T9AwVDiKn8OMkj1UkFCnQ1YXTbO95NDOUtK8jf0YKO+DgiWzJZWuWXCuwVYMj3yPh b4XAtqw2OnAVXmXLPzp8u4Cd8vmkuS4V4XIHpx9ZoaLgnEoWj09kHZXY5H4eag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697632240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t7LUO13cI7H7bPbnkXhsWsVeYwPrjJ1PCNXk0Ix/MJg=; b=c1f12xwIoA92lvJkELqemaS53VMQcQxxK9hlda/DRRMFuretsqimLzrcQVshA/l41jh2g8 eWYyu1BKyRLCwBknuNe4NDbFgbDbE3wiWoqgxewy2S6Cx1LOrdtyDnfCGDSQQk39csqVxP +t8cEjubqUiYM+1G/NSaTNo1XoDfm0jx+Mp6mtQOOCSf+X7wCvbBuJUKNMPK9z4ogyp93C 0UIQkLLLLH9wzmnqTTtgvNOSJohkweKLDAm2n5NISndGjZvXnsmxQBGf8KF49XVN0q5Gvq oWtHIjl7oXsaJNcfABIdAyX132nxZlLzM2KTSzHKT9t7VLD8qgtdXmy1S3iLmg== Received: from [192.168.1.9] (mob-5-91-126-91.net.vodafone.it [5.91.126.91]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: asiciliano) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S9VYq72hGz6Zx; Wed, 18 Oct 2023 12:30:39 +0000 (UTC) (envelope-from asiciliano@FreeBSD.org) Message-ID: <0fe92251-c75a-4074-9640-9af8ce0bf8b1@FreeBSD.org> Date: Wed, 18 Oct 2023 14:30:41 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8cfbeb56aa16 - main - bsdinstall services: Improve mouse configuration To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202205211442.24LEgsv9085401@gitrepo.freebsd.org> <99742C19-34A6-461F-BEA7-6B9206DF42C9@freebsd.org> Content-Language: en-US From: "Alfonso S. Siciliano" In-Reply-To: <99742C19-34A6-461F-BEA7-6B9206DF42C9@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/10/2022 22:38, Jessica Clarke wrote: > On 21 May 2022, at 15:42, Alfonso S. Siciliano wrote: >> >> The branch main has been updated by asiciliano: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=8cfbeb56aa160de1ea4f492abeb3aa029e84269f >> >> commit 8cfbeb56aa160de1ea4f492abeb3aa029e84269f >> Author: Alfonso S. Siciliano >> AuthorDate: 2022-05-21 14:37:53 +0000 >> Commit: Alfonso S. Siciliano >> CommitDate: 2022-05-21 14:42:23 +0000 >> >> bsdinstall services: Improve mouse configuration >> >> bsdinstall(8) has an option to enable moused support. >> However, if it is not selected, moused is still started >> through the configuration of nondefault devices. >> So, automatically add the moused_nondefault_enable="NO" >> setting to rc.conf unless moused support is selected. >> >> PR: 227999 >> Reported by: bcran >> Reviewed by: bapt >> Differential Revision: https://reviews.freebsd.org/D35193 > > I question the wisdom of this change. The text specifically says “PS/2 > mouse pointer”, because moused_enable controls only the default mouse, > which rc.conf sets to /dev/psm0. Turning this option on or off would > therefore affect specifically the PS/2 mouse, precisely as described in > the dialog menu entry. USB mice would always remain enabled. > > However, now, leaving the explicitly-PS/2 mouse option disabled *also* > disables non-default, i.e. USB, mice. Moreover, if you go and enable > the option so USB mice work, PS/2 mice are always enabled, but you may > not have a /dev/psm0. You may even be on an architecture where PS/2 > does not exist; atkbdc, and thus psm, only exists for x86. This means > that, in those cases, enabling the option gives an error during boot > because /dev/psm0 doesn’t exist. > > I can understand that some people want to turn off console mouse > support completely; however, with the current way moused works, that > cannot just be a single option that governs both moused_enable and > moused_nondefault_enable. > > Jess > I'll revert this commit. The comment could be added to the PR to track the discussion only in one place. Alfonso >> --- >> usr.sbin/bsdinstall/scripts/services | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/usr.sbin/bsdinstall/scripts/services b/usr.sbin/bsdinstall/scripts/services >> index f9141a523a31..1ac69fa63b2d 100755 >> --- a/usr.sbin/bsdinstall/scripts/services >> +++ b/usr.sbin/bsdinstall/scripts/services >> @@ -61,11 +61,17 @@ if [ $retval -ne $BSDDIALOG_OK ]; then >> fi >> >> havedump= >> +havemouse= >> for daemon in $DAEMONS; do >> [ "$daemon" = "dumpdev" ] && havedump=1 continue >> + [ "$daemon" = "moused" ] && havemouse=1 >> echo ${daemon}_enable=\"YES\" >> $BSDINSTALL_TMPETC/rc.conf.services >> done >> >> +if [ ! "$havemouse" ]; then >> + echo moused_nondefault_enable=\"NO\" >> $BSDINSTALL_TMPETC/rc.conf.services >> +fi >> + >> echo '# Set dumpdev to "AUTO" to enable crash dumps, "NO"' \ >> 'to disable' >> $BSDINSTALL_TMPETC/rc.conf.services >> if [ "$havedump" ]; then >