From owner-p4-projects@FreeBSD.ORG Thu Dec 7 13:02:28 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 69AB316A517; Thu, 7 Dec 2006 13:02:28 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0BC1916A511 for ; Thu, 7 Dec 2006 13:02:28 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6698643CAA for ; Thu, 7 Dec 2006 13:00:52 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 33784 invoked from network); 7 Dec 2006 12:49:57 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 7 Dec 2006 12:49:57 -0000 Message-ID: <457810AC.9080406@freebsd.org> Date: Thu, 07 Dec 2006 14:01:32 +0100 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) MIME-Version: 1.0 To: Gleb Smirnoff References: <200612062319.kB6NJgsq031755@repoman.freebsd.org> <20061207110225.GU32700@FreeBSD.org> <4578070A.2030609@freebsd.org> <20061207124112.GW32700@FreeBSD.org> In-Reply-To: <20061207124112.GW32700@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews , Paolo Pisati Subject: Re: PERFORCE change 111230 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2006 13:02:28 -0000 Gleb Smirnoff wrote: > On Thu, Dec 07, 2006 at 01:20:26PM +0100, Andre Oppermann wrote: > A> Gleb Smirnoff wrote: > A> >On Wed, Dec 06, 2006 at 11:19:42PM +0000, Paolo Pisati wrote: > A> >P> http://perforce.freebsd.org/chv.cgi?CH=111230 > A> >P> > A> >P> Change 111230 by piso@piso_newluxor on 2006/12/06 23:19:06 > A> >P> > A> >P> To workaround a problem when an mbuf is bigger than MCLBYTES > A> >P> (and thus not handled by m_megapullup()), introduce & use > A> >P> m_jumbo16pullup() that uses 16k jumbo size cluster. > A> >P> > A> >P> This problem only showed up on traffic generated on a box with > A> >P> a nic tso enabled. > A> > > A> >Paolo, > A> > > A> >this isn't a fix. Another application will do write(,, 16k + 1) and > A> >m_jumbo16pullup() will fail again. Please backout it, it is a hack. > A> > > A> >We need to fix TSO in such way that real packets, that will be > A> >transmitted to wire, will be passed to pfil handlers. > A> > A> That is not possible. > > ATM this should be at least documented behavior. And a solution should > be thought, because pfil must see real packets, not their precursors. I fully agree about the documentation. Fixing TSO pass 'packets' to pfil is not possible as that equals disabling TSO in the first place. The user has to chose what he needs more, pfil correctly counting packet, or the performance benefits of TSO. Can't have both at the same time. On routers and firewalls TSO is not much of an issues. -- Andre