From nobody Tue Dec 16 23:43:33 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dWD5d6RW5z6LPZM for ; Tue, 16 Dec 2025 23:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dWD5d22DYz3H5J for ; Tue, 16 Dec 2025 23:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765928613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s2S2UlcXuHkLEwr3YjDhJxCMDW4VLZW1ox/mfZ/VS/8=; b=hjLVPAHkzNGivLnrb35jlSgtJTM5mpQ7FUwRwuCKalQY9G0bjX1Kc/xJGGSTf+pmrwJKFW W0cF8YD4rTeCzhcUGz906jDTLIqDgZWSH89QSSqnYThRtMtLPHgdSS4gl3BvgAu4tBUcKv 0OKv5NjSakQZdXIKqiz2TQbWNcMBNENeslek5fj57VrfT+1EXNpDji9hbQzMG2xZ1O1Fc7 uaiM/LbxwMEU7TL2lgSsbUxs9EGKjH8g6G11NjwkrW9QVUSxjDCRk8bEcZHYK92xqXkDxw IQ3dgnZHq+Kp+I0ZRNE5dUWlAlIf6RQzdcHAp5y+9eG9LzJHLR6yOzwbJVyV6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765928613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s2S2UlcXuHkLEwr3YjDhJxCMDW4VLZW1ox/mfZ/VS/8=; b=vhlXcKYX317V9Q2ZB4jfD+AA7oxzSFIrpVtaLnz4W8lkK/8xakJ9zDM1NZE5ZrFAxFpie7 8KIhDo6KdGos3x3R+4mMil3Lxn3GLJxRIKif2Lev3WFAHlWuz6ZtKAiZj0tPqynkO4ggZu lFGAk+MvldVsKwl9hYB0PcHVyJzajOTAU6/dPlCwkz73x1c7WDjUhKgIZSpDcVGlqeFXBm RZZnczjbJrCFVMhoVOfeae09pqgiokzvtc5owAp8Jl2ebl2/YyBF68pS6gZnyIZUrB0/ni nZtnpzn6w9yhTgKogbZxEyYK8+ljF9vSCOTJZI8nSkeXgV2KLe8ZLZHh3p6IeA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765928613; a=rsa-sha256; cv=none; b=okjLLK/ifQRY4U0EXn8UarE3kOozf4NJqmh+LmGnaMccIBAqyaIaSFDm/0f9WWmJhRgHQW r2oEm4iXcSU+84Qf7CbA/xqmJtN97omAgyModq18hcY6YsA/7L/mv3I7+YePpJrF6fxLcp FNMJzjQAtx3yaI6OgErDY8bTYvcygvl3E7ydeecDS3YbMGAGQ7nuHHdF4s1NXB6Z87lUlk xhVjrTwWYjlvgXzMbAajb1CsisLZBAA5j7heCVXKeX5jRHzAs6wUIAqfFq/nRJ5Dw51w5x bwDjB+BZV7K5BeOG3ScdWbq45K9fRjeSwocARs29Wxf5zDdPOhHkX1nUsv7Zgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dWD5d1dbyzCS6 for ; Tue, 16 Dec 2025 23:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2411b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 16 Dec 2025 23:43:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 35cee6a90119 - releng/13.5 - rtsold: Validate entries in domain search lists List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.5 X-Git-Reftype: branch X-Git-Commit: 35cee6a90119cc5d123f705544433164a7a9227a Auto-Submitted: auto-generated Date: Tue, 16 Dec 2025 23:43:33 +0000 Message-Id: <6941eea5.2411b.35034f07@gitrepo.freebsd.org> The branch releng/13.5 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=35cee6a90119cc5d123f705544433164a7a9227a commit 35cee6a90119cc5d123f705544433164a7a9227a Author: Mark Johnston AuthorDate: 2025-12-15 20:50:08 +0000 Commit: Mark Johnston CommitDate: 2025-12-16 23:41:40 +0000 rtsold: Validate entries in domain search lists Reported by: Kevin Day Approved by: so Security: FreeBSD-SA-25:12.rtsold Security: CVE-2025-14558 --- usr.sbin/rtsold/rtsol.c | 46 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/usr.sbin/rtsold/rtsol.c b/usr.sbin/rtsold/rtsol.c index 187aa44f6740..72573c2eb4b0 100644 --- a/usr.sbin/rtsold/rtsol.c +++ b/usr.sbin/rtsold/rtsol.c @@ -764,6 +764,41 @@ call_script(const char *const argv[], struct script_msg_head_t *sm_head) argv[0], status); } +#define PERIOD 0x2e +#define hyphenchar(c) ((c) == 0x2d) +#define periodchar(c) ((c) == PERIOD) +#define alphachar(c) (((c) >= 0x41 && (c) <= 0x5a) || \ + ((c) >= 0x61 && (c) <= 0x7a)) +#define digitchar(c) ((c) >= 0x30 && (c) <= 0x39) + +#define borderchar(c) (alphachar(c) || digitchar(c)) +#define middlechar(c) (borderchar(c) || hyphenchar(c)) + +static int +res_hnok(const char *dn) +{ + int pch = PERIOD, ch = *dn++; + + while (ch != '\0') { + int nch = *dn++; + + if (periodchar(ch)) { + ; + } else if (periodchar(pch)) { + if (!borderchar(ch)) + return (0); + } else if (periodchar(nch) || nch == '\0') { + if (!borderchar(ch)) + return (0); + } else { + if (!middlechar(ch)) + return (0); + } + pch = ch, ch = nch; + } + return (1); +} + /* Decode domain name label encoding in RFC 1035 Section 3.1 */ static size_t dname_labeldec(char *dst, size_t dlen, const char *src) @@ -792,12 +827,11 @@ dname_labeldec(char *dst, size_t dlen, const char *src) } *dst = '\0'; - /* - * XXX validate that domain name only contains valid characters - * for two reasons: 1) correctness, 2) we do not want to pass - * possible malicious, unescaped characters like `` to a script - * or program that could be exploited that way. - */ + if (!res_hnok(dst_origin)) { + warnmsg(LOG_INFO, __func__, + "invalid domain name '%s' was ignored", dst_origin); + return (0); + } return (src - src_origin); }