From owner-svn-src-all@freebsd.org  Tue Mar 28 10:26:08 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1F6DD1FFF7;
 Tue, 28 Mar 2017 10:26:08 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au
 [211.29.132.249])
 by mx1.freebsd.org (Postfix) with ESMTP id 8948DEFC;
 Tue, 28 Mar 2017 10:26:08 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au
 [122.106.153.191])
 by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id B15C31040F1B;
 Tue, 28 Mar 2017 20:51:49 +1100 (AEDT)
Date: Tue, 28 Mar 2017 20:51:48 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Warner Losh <imp@bsdimp.com>
cc: Bruce Evans <brde@optusnet.com.au>, Warner Losh <imp@freebsd.org>, 
 src-committers <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r316064 - head/sys/boot/i386/boot2
In-Reply-To: <CANCZdfrJNrk3h-vGzBcWkguWM3VimasYajxFgyOA9okPe5Ghrw@mail.gmail.com>
Message-ID: <20170328203618.N1920@besplex.bde.org>
References: <201703272253.v2RMra2L032487@repo.freebsd.org>
 <20170328141213.T927@besplex.bde.org>
 <CANCZdfrJNrk3h-vGzBcWkguWM3VimasYajxFgyOA9okPe5Ghrw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=AYLBJzfG c=1 sm=1 tr=0
 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17
 a=kj9zAlcOel0A:10 a=ecsj_lGnN_rLbzqxT6gA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2017 10:26:08 -0000

On Tue, 28 Mar 2017, Warner Losh wrote:

> [[ sorry for the top post but it's quick ]]

It's quicker and almost equivalent to delete what you reply to.

> Summary, in Bruce's own words
>
>> the whole optimization step was silly.
>
> I agree. on my -current system, clang compiled boot2 was 4 bytes
> smaller after ripping it out. gcc was a whopping 7 bytes larger. Since
> gcc has 156 still free, I think it's best to just retire this.
>
> Maybe you can give me a hint as to which structs to look at to get
> back those 7 bytes :)

Just sort the character arrays to get back 4.  Maybe clang already does
this, though I like getting the same order as in the sources.

Reducing 1 of the arrays by 1 byte would then save 1 and get back the
other 3.

Bruce