From owner-svn-ports-all@freebsd.org  Mon Jul  1 07:34:50 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 596E615D5110;
 Mon,  1 Jul 2019 07:34:50 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E893469AF6;
 Mon,  1 Jul 2019 07:34:49 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D798315C6E; Mon,  1 Jul 2019 07:34:49 +0000 (UTC)
Date: Mon, 1 Jul 2019 07:34:49 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Larry Rosenman <ler@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r505444 - head/sysutils/lsof
Message-ID: <20190701073449.GA76737@FreeBSD.org>
References: <201906301915.x5UJFU4J074561@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201906301915.x5UJFU4J074561@repo.freebsd.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-Rspamd-Queue-Id: E893469AF6
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.78 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.78)[-0.784,0]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jul 2019 07:34:50 -0000

On Sun, Jun 30, 2019 at 07:15:30PM +0000, Larry Rosenman wrote:
> New Revision: 505444
> URL: https://svnweb.freebsd.org/changeset/ports/505444
> 
> Log:
>   sysutils/lsof: quiet portlint.

This is very bad commit message, it explains nothing.  Moreover,
appealing to portling(1), blindly lihe this, is usually bogus and
wrong.

> Modified: head/sysutils/lsof/Makefile
> @@ -31,7 +31,7 @@ CONFIGURE_ARGS=	-n freebsd
>  CONFIGURE_ENV=	LSOF_CC="${CC}" FREEBSD_SYS="${SRC_BASE}/sys"
>  
>  .if !exists(${SRC_BASE}/sys/kern/kern_lockf.c)
> -IGNORE=		requires kernel sources
> +IGNORE+=		requires kernel sources
>  .endif

That said, could you explain the scenario (like, what make(1) commands
and under what circumstances I must type) to demonstrate what was wrong
here before and how did your commit fix it?

./danfe