From owner-freebsd-fs@FreeBSD.ORG Mon Sep 3 17:25:18 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11FD7106564A for ; Mon, 3 Sep 2012 17:25:18 +0000 (UTC) (envelope-from matthew.ahrens@delphix.com) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by mx1.freebsd.org (Postfix) with ESMTP id C27F38FC16 for ; Mon, 3 Sep 2012 17:25:17 +0000 (UTC) Received: by iebc12 with SMTP id c12so4757892ieb.13 for ; Mon, 03 Sep 2012 10:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphix.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Y/X+FNS1CRpHYafi7uBEEAsVYlMeeGmTCYCnS6eGgIo=; b=DhIVJJ7vu4X9kSleZIxtvrg2Wp1hXgo0OIIlIaBN5xfnvpmKyW00MpUZYFsiDT0zj7 MN9HKs0gD2N181PwxvumnO7hyJdrwdJEXPMqN6aKfYPIgBSNtftTaVX1yXG3qMJ5Btwu OfTcBKD5yubGfiix9fY4uZ7TLee6aUToYoj1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=Y/X+FNS1CRpHYafi7uBEEAsVYlMeeGmTCYCnS6eGgIo=; b=LQtjaiW8HutwZIkthDS/lLmRPhMN43+7N19+Tf1MTf7IXmfgmX3eDxZV6rYtrQJGWm b5cK7OMolmSEGiB+GK1hup5AYsH1Uy24ZcOhi6P6Z95ZpM9FX1DazzrRb4/nIzVWmktw OMDl2b9CziZI2KVWYgBIIVvEkipAvgJcLbPAi1LoRuKONdXkRaNyAnNzWq25PWgVnDvU Xw4FpeLdM+vUi7btf0jozed2pBVvRfGcAUYNIMqj/mWUnANdTxQ4KGJIR3D87B29T7IZ 3DuU6RwWCJb0oSGRDnXmlVfW5zFix2hp9RFIOAOauBaF8w4R2c3nuWLBMTcnobbcsy4n yO/w== MIME-Version: 1.0 Received: by 10.50.237.38 with SMTP id uz6mr11474114igc.2.1346693117132; Mon, 03 Sep 2012 10:25:17 -0700 (PDT) Received: by 10.50.0.140 with HTTP; Mon, 3 Sep 2012 10:25:17 -0700 (PDT) In-Reply-To: <5043B866.6060204@nexenta.com> References: <50438BF5.8030004@gibfest.dk> <5043B0CB.8040907@gibfest.dk> <20120902193100.GG1266@glenbarber.us> <5043B866.6060204@nexenta.com> Date: Mon, 3 Sep 2012 10:25:17 -0700 Message-ID: From: Matthew Ahrens To: Yuri Pankov Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnPo0PpldiHFrdAVLYpK4I7dhTDQx2onxI44R11tyVlQY/+ubbqnCr+t8x8nS0fzCE7jrqb Cc: freebsd-fs , illumos-zfs Subject: Re: zfs send -r missing - but documented in zfs(8) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 17:25:18 -0000 On Sun, Sep 2, 2012 at 12:49 PM, Yuri Pankov wrote: > On Sun, 2 Sep 2012 15:31:00 -0400, Glen Barber wrote: >> >> On Sun, Sep 02, 2012 at 09:17:31PM +0200, Thomas Steen Rasmussen wrote: >>>> >>>> Hello list, >>>> >>>> For some reason it seems like the -r argument to "zfs send" isn't >>>> implemented in FreeBSD. It is documented in the usage output >>>> seen below: >>>> >>>> >>>> I had a similar experience with out-of-sync docs and then I think a >>>> missing mergemaster might have had something to do with it. >>>> >>> Hello, >>> >>> This is not just the manpage out of sync. Ironically >>> the zfs tool itself reports the lower-case -r option >>> in the usage output that it shows me because -r >>> is an invalid option: >>> >>> ------------------------------------------------------------ >>> $ zfs send -r >>> invalid option 'r' >>> usage: >>> send [-DnPpRrv] [-i snapshot | -I snapshot] >>> >> >> I reported this to Martin a few days ago, but not yet had time myself to >> check if this is also a bug upstream. > > > Talking about upstream, looks like -r was added to usage and man page in > r13524 by Matthew Ahrens (CCed), but the functionality itself is missing. Indeed. This was a mistake. A long time ago we intended to implement this flag, but it was never integrated. I think I typo'ed the options string in the zfs command; and then when writing the manpage I remembered that long-lost implementation. In any case, we should remove the documentation of the "zfs send -r" flag, as that flag doesn't actually exist. --matt