From owner-cvs-all@FreeBSD.ORG Tue Feb 27 17:23:09 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7DD4416A401; Tue, 27 Feb 2007 17:23:09 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 3A99A13C4A8; Tue, 27 Feb 2007 17:23:09 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 242342087; Tue, 27 Feb 2007 18:23:05 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id 13648207E; Tue, 27 Feb 2007 18:23:05 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 1001) id EB3BBB874; Tue, 27 Feb 2007 18:23:04 +0100 (CET) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Sam Leffler References: <200702242355.l1ONtlSE066370@repoman.freebsd.org> <86mz2zwq93.fsf@dwp.des.no> <45E461B5.9000404@errno.com> Date: Tue, 27 Feb 2007 18:23:04 +0100 In-Reply-To: <45E461B5.9000404@errno.com> (Sam Leffler's message of "Tue, 27 Feb 2007 08:52:05 -0800") Message-ID: <86fy8rms5j.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig af_atalk.c af_inet.c af_inet6.c af_ipx.c af_link.c ifconfig.c ifconfig.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 17:23:09 -0000 Sam Leffler writes: > Dag-Erling Sm=F8rgrav wrote: > > This commit breaks interface cloning. Apparently, the global variable > > "name" is not initialized before ifclonecreate() is called, so the > > SIOCIFCREATE2 ioctl() is called with an empty string instead of the > > interface name. > Hmm, worked for bridge for me. Can you provide the specific example? Is "ifconfig bridge0 create" specific enough? Insert a printf() in the right spot and you'll see name is empty when ifclonecreate() is called. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no