From owner-svn-src-head@FreeBSD.ORG Thu Aug 15 10:18:27 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7BEE2186; Thu, 15 Aug 2013 10:18:27 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DE5EC24E4; Thu, 15 Aug 2013 10:18:25 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r7FAINte005749; Thu, 15 Aug 2013 14:18:23 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r7FAINdR005748; Thu, 15 Aug 2013 14:18:23 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 15 Aug 2013 14:18:23 +0400 From: Gleb Smirnoff To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r254358 - head/sys/sys Message-ID: <20130815101823.GH4574@FreeBSD.org> References: <201308150821.r7F8L03R023939@svn.freebsd.org> <20130815082505.GD4574@FreeBSD.org> <20130815085404.GD76693@caravan.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130815085404.GD76693@caravan.chchile.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2013 10:18:27 -0000 On Thu, Aug 15, 2013 at 10:54:04AM +0200, Jeremie Le Hen wrote: J> On Thu, Aug 15, 2013 at 12:25:05PM +0400, Gleb Smirnoff wrote: J> > On Thu, Aug 15, 2013 at 08:21:00AM +0000, Jeremie Le Hen wrote: J> > J> Author: jlh J> > J> Date: Thu Aug 15 08:21:00 2013 J> > J> New Revision: 254358 J> > J> URL: http://svnweb.freebsd.org/changeset/base/254358 J> > J> J> > J> Log: J> > J> Belatedly bump __FreeBSD_version for libc being an ld script. J> > J> This should have been done in r251668, on June 12, 2013. J> > J> This will have no practical consequences, besides having -lssp_nonshared J> > J> appearing twice on the command-line for systems built in this time frame. J> > J> > It has been bumped several times since June 12. J> > J> > You could use __FreeBSD_version 1000036 from r253049, which J> > happened on July 7. J> J> That's right, but I didn't know if it was accepted to overload a J> version. Should I back this out? IMO, version should never go backwards. So please do not back out. But the code that depends on libc being an ld script should better use 1000036 as __FreeBSD_version, making time frame of non-bumped version much smaller. -- Totus tuus, Glebius.