Date: Tue, 13 Jan 2009 01:58:05 GMT From: Vlad GURDIGA <gurdiga@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/130481: xterm should be built with Unicode support by default Message-ID: <200901130158.n0D1w5cM008516@www.freebsd.org> Resent-Message-ID: <200901130200.n0D202iF076907@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 130481
>Category: ports
>Synopsis: xterm should be built with Unicode support by default
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Jan 13 02:00:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Vlad GURDIGA
>Release: 7.0
>Organization:
TKMD
>Environment:
FreeBSD kpax 7.0-RELEASE-p7 FreeBSD 7.0-RELEASE-p7 #0: Sun Dec 21 12:33:45 UTC 2008 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
After updating my xterm port, uxterm stopped working saying that:
% uxterm
xterm: bad command line option "-u8"
usage: xterm [-/+132] [-C] [-Sccn] [-T string] [-/+ah] [-/+ai] [-/+aw]
[-b number] [-/+bc] [-bcf milliseconds] [-bcn milliseconds] [-bd color]
[-/+bdc] [-bg color] [-bw number] [-/+cb] [-cc classrange] [-class string]
[-/+cm] [-/+cn] [-cr color] [-/+cu] [-/+dc] [-display displayname]
[-e command args ...] [-fa pattern] [-fb fontname] [-/+fbb] [-/+fbx]
[-fd pattern] [-fg color] [-fi fontname] [-fn fontname] [-fs size]
[-fx fontname] [#geom] [%geom] [-geometry geom] [-help] [-/+hm] [-/+hold]
[-iconic] [-/+ie] [-/+im] [-into windowId] [-/+j] [-/+k8]
[-kt keyboardtype] [-/+l] [-leftbar] [-lf filename] [-/+ls] [-/+mb]
[-mc milliseconds] [-/+mesg] [-ms color] [-n string] [-name string]
[-nb number] [-/+nul] [-/+pc] [-/+pob] [-rightbar] [-/+rv] [-/+rvc] [-/+rw]
[-/+s] [-/+samename] [-/+sb] [-selbg color] [-selfg color] [-/+sf] [-/+si]
[-/+sk] [-sl number] [-/+sm] [-/+sp] [-/+t] [-ti termid] [-title string]
[-tm string] [-tn name] [-/+uc] [-/+ulc] [-/+ulit] [-/+ut] [-/+vb]
[-version] [-/+wf] [-xrm resourcestring] [-ziconbeep percent]
Type xterm -help for a full description.
%
Then I found in the x11/xterm Makefile this:
.if defined(WITH_WIDE_CHARS)
CONFIGURE_ARGS+= --enable-wide-chars --enable-luit
.endif
and, of course after I've rebuilt x11/xterm with "make
-DWITH_WIDE_CHARS" everything worked. I guess if the uxterm wrapper
script is installed, then WITH_WIDE_CHARS should probably be enabled
by default.
>How-To-Repeat:
1. Update ports tree.
2. Rebuild the x11/xterm port.
3. Try running uxterm or "xterm -u8".
>Fix:
Proposed by Ashish SHUKLA <wahjava.ml@gmail.com>:
I think this should be in the OPTIONS variable of xterm port's Makefile. Because this variable is not even documented anywhere and you won't notice this unless you're in habit of reading the port Makefile.
Patch attached with submission follows:
--- Makefile.old 2009-01-11 13:05:41.000000000 +0200
+++ Makefile.new 2009-01-13 03:46:03.000000000 +0200
@@ -22,11 +22,8 @@
GNU_CONFIGURE= yes
CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
LIBS="-L${LOCALBASE}/lib"
-CONFIGURE_ARGS+=--with-utempter --enable-narrowproto
-
-.if defined(WITH_WIDE_CHARS)
-CONFIGURE_ARGS+= --enable-wide-chars --enable-luit
-.endif
+CONFIGURE_ARGS+=--with-utempter --enable-narrowproto \
+ --enable-wide-chars --enable-luit
.if defined(WITH_256_COLOR)
CONFIGURE_ARGS+= --enable-256-color
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901130158.n0D1w5cM008516>