From owner-freebsd-current  Sun Oct 27 19:55:45 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5FBE337B401; Sun, 27 Oct 2002 19:55:43 -0800 (PST)
Received: from pozo.com (pozo.com [216.101.162.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C1FB643E4A; Sun, 27 Oct 2002 19:55:42 -0800 (PST)
	(envelope-from null@pozo.com)
Received: from quad.pozo.com (quad.pozo.com [216.101.162.53])
	by pozo.com (8.12.6/8.12.6) with ESMTP id g9S3tdxY002024
	(version=TLSv1/SSLv3 cipher=DES-CBC3-SHA bits=168 verify=NO);
	Sun, 27 Oct 2002 19:55:39 -0800 (PST)
	(envelope-from null@pozo.com)
Message-Id: <5.1.1.6.2.20021027195512.00a882b8@pozo.com>
X-Sender: null@pozo.com
X-Mailer: QUALCOMM Windows Eudora Version 5.1.1
Date: Sun, 27 Oct 2002 19:55:38 -0800
To: Craig Rodrigues <rodrigc@attbi.com>
From: Manfred Antar <null@pozo.com>
Subject: Re: Latest fetch on current broken
Cc: current@freebsd.org, des@freebsd.org
In-Reply-To: <20021027223836.A51789@attbi.com>
References: <20021027222102.A51684@attbi.com>
 <5.1.1.6.2.20021027153430.00a796a8@pozo.com>
 <5.1.1.6.2.20021027153430.00a796a8@pozo.com>
 <20021027212702.A51436@attbi.com>
 <5.1.1.6.2.20021027183013.00abaec0@pozo.com>
 <20021027222102.A51684@attbi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

At 10:38 PM 10/27/2002 -0500, Craig Rodrigues wrote:
>On Sun, Oct 27, 2002 at 10:21:02PM -0500, Craig Rodrigues wrote:
>> On Sun, Oct 27, 2002 at 06:31:27PM -0800, Manfred Antar wrote:
>> > I noticed it when doing a portupgrade cdrtools
>> > So yes anything that uses fetch is not going to work
>> 
>> OK, I started tracing this down.
>> 
>> Here's how to get debugging versions:
>> cd /usr/src/lib/libfetch
>> make clean
>> make DEBUG_FLAGS=-g 
>> make DEBUG_FLAGS=-g  install
>> 
>> cd /usr/src/usr.bin/fetch
>> make clean
>> make DEBUG_FLAGS=-g NOSHARED=yes
>> make DEBUG_FLAGS=-g NOSHARED=yes install
>
>
>I tracked this down further to the _fetch_writev() function
>in libfetch/common.c.  Try this patch:
>
>--- lib/libfetch/common.c.orig  Sun Oct 27 22:38:16 2002
>+++ lib/libfetch/common.c       Sun Oct 27 22:40:12 2002
>@@ -525,7 +525,7 @@
>                        return (-1);
>                }
>                total += wlen;
>-               while (iovcnt > 0 && wlen > iov->iov_len) {
>+               while (iovcnt > 0 && wlen >= iov->iov_len) {
>                        wlen -= iov->iov_len;
>                        iov++;
>                        iovcnt--;
>
>-- 
>Craig Rodrigues        
>http://www.gis.net/~craigr    
>rodrigc@attbi.com 

This change makes it work here

Manfred

==================================
||      null@pozo.com           ||
||      Ph. (415) 681-6235      ||
==================================


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message