From owner-cvs-all@FreeBSD.ORG Thu May 8 00:24:58 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 688CC106567A for ; Thu, 8 May 2008 00:24:58 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA02.emeryville.ca.mail.comcast.net (qmta02.emeryville.ca.mail.comcast.net [76.96.30.24]) by mx1.freebsd.org (Postfix) with ESMTP id 3CEBD8FC22 for ; Thu, 8 May 2008 00:24:57 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA12.emeryville.ca.mail.comcast.net ([76.96.30.44]) by QMTA02.emeryville.ca.mail.comcast.net with comcast id NnZY1Z0010x6nqcA205U00; Thu, 08 May 2008 00:22:55 +0000 Received: from discordia ([24.60.135.75]) by OMTA12.emeryville.ca.mail.comcast.net with comcast id NoQk1Z0051dmTCQ8Y00000; Thu, 08 May 2008 00:24:46 +0000 X-Authority-Analysis: v=1.0 c=1 a=OkG7nnxKhZwA:10 a=0ndhUXHMI6sA:10 a=kfYdCqaChhrBYW9akngA:9 a=I_9tmNnggA9T7ZUcoMIA:7 a=diaZ4OFGjud4Tt0AASvd_UGWvdoA:4 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 a=RTfWyorAT3np2gD2ZZsA:9 a=Ohv0qBKTvhPFk4zHVfra0_Z2-HgA:4 a=rPt6xJ-oxjAA:10 Received: by discordia (Postfix, from userid 103) id E7BC016B55D; Wed, 7 May 2008 20:24:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 4093D16B55B; Wed, 7 May 2008 20:24:29 -0400 (EDT) From: Coleman Kane To: Kris Kennaway In-Reply-To: <48223918.4010001@FreeBSD.org> References: <200805051603.m45G3rrN089219@repoman.freebsd.org> <200805051637.43073.jhb@freebsd.org> <20080507064013.GU32532@elvis.mu.org> <200805071111.39938.jhb@freebsd.org> <20080507231444.GF32532@elvis.mu.org> <48223918.4010001@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-7rXz3tlKfCMlll+qDCtd" Organization: FreeBSD Project Date: Wed, 07 May 2008 20:23:04 -0400 Message-Id: <1210206184.1679.6.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 FreeBSD GNOME Team Port Cc: src-committers@freebsd.org, John Baldwin , Alfred Perlstein , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2008 00:24:58 -0000 --=-7rXz3tlKfCMlll+qDCtd Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2008-05-08 at 01:19 +0200, Kris Kennaway wrote: > Alfred Perlstein wrote: > > * John Baldwin [080507 10:28] wrote: > >> On Wednesday 07 May 2008 02:40:13 am Alfred Perlstein wrote: > >>> * John Baldwin [080505 13:47] wrote: > >>>> On Monday 05 May 2008 03:24:17 pm Peter Jeremy wrote: > >>>>> On Mon, May 05, 2008 at 02:59:28PM -0400, John Baldwin wrote: > >>>>>> On Monday 05 May 2008 02:40:03 pm Alfred Perlstein wrote: > >>>>>>> I'm _not_ objecting, just interested in why. > >>>>>>> > >>>>>>> Any references to discussions on this? Are we now safe for > >>>>>>> future compat or something? > >>>>>> Having FILE be opaque broke just about every 'configure' script on= the=20 > >>>>>> planet. :( > >>>>> Either autoconf and friends are _intended_ as impediments to > >>>>> portability or they are completely broken by design. > >>>> It appears that autoconf only believes a type is real if you can typ= edef=20 > >> it to=20 > >>>> another type, cast 0 to a valid pointer to the new typedef'd type, a= nd do=20 > >> a=20 > >>>> sizeof() of the typdef'd type. The last is where having an opaque t= ype=20 > >>>> breaks down for scripts that want to make sure FILE is a real type. > >>> > >>> Oh c'mon! we're going to revert this needed fix just because of > >>> autoconf? > >> Pretty much. It appears that FILE has been public for so long that th= ere is a=20 > >> lot of code that assumes it can use it. > >=20 > > I don't think that's really fair, stdio has had adequate accessors > > for a long time, if AN(*) application does the wrong thing for long eno= ugh > > it does not make it right. > >=20 > > (*) Important note: when considering autoconf scripts, most of the > > scripts test's come from a repository of scripts or are carbon > > copied from each other. Saying that "all ports are broken" is not > > true, it is a single suite of configuration scripts that are broken > > and need fixing, then we will be OK. > >=20 > > We have precident here of hacked autoconf and ports build logic > > that automatically "seds" various things in scripts. I think > > a few knobs can fix this for us. >=20 > The offer was a serious one. If you're interested in evaluating the=20 > impact of this change on ports then just say the word. >=20 > Kris >=20 What if we fix this breakage through a patch in our autoconf/automake and then put a toggle in the ports system that could be told to re-run autogen on the offending ports before the configure script is run (hopefully replacing the broken "configure" with one that works)? On an embedded Linux system I am working with, I've been using this approach to fix some "host machine arch not found" errors. I would be able to live with ports being broken for a bit if it means we can get the change in... I'd even put in some time that I can to help fix the ones that I depend upon. --=20 Coleman Kane --=-7rXz3tlKfCMlll+qDCtd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkgiR+IACgkQcMSxQcXat5fpWwCfbsyVssYYd09i3/ZEiFIsM1p+ 28oAni9i1lC/PMdKoUmwliTPMBVHi8Iu =N39M -----END PGP SIGNATURE----- --=-7rXz3tlKfCMlll+qDCtd--