From owner-svn-src-all@FreeBSD.ORG  Tue Oct 23 10:16:20 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C8917494;
 Tue, 23 Oct 2012 10:16:20 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 42E028FC08;
 Tue, 23 Oct 2012 10:16:20 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9NAGIg3084093;
 Tue, 23 Oct 2012 14:16:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9NAGIhn084092;
 Tue, 23 Oct 2012 14:16:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 23 Oct 2012 14:16:18 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Re: svn commit: r241923 - in head/sys: netinet netipsec
Message-ID: <20121023101618.GP70741@FreeBSD.org>
References: <201210230833.q9N8XEas020937@svn.freebsd.org>
 <50865F60.4040409@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <50865F60.4040409@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 10:16:20 -0000

On Tue, Oct 23, 2012 at 11:12:00AM +0200, Andre Oppermann wrote:
A> On 23.10.2012 10:33, Gleb Smirnoff wrote:
A> > Author: glebius
A> > Date: Tue Oct 23 08:33:13 2012
A> > New Revision: 241923
A> > URL: http://svn.freebsd.org/changeset/base/241923
A> >
A> > Log:
A> >      Do not reduce ip_len by size of IP header in the ip_input()
A> >    before passing a packet to protocol input routines.
A> >      For several protocols this mean that now protocol needs to
A> >    do subtraction itself, and for another half this means that
A> >    we do not need to add header length back to the packet.
A> 
A> Yay! More Mammoth shit getting washed away! ;)
A> 
A> Please add an entry to UPDATING as the convention of of ip_len
A> subtraction has been there since forever. That makes it easier
A> to discover for third parties writing code.

Not sure it worth. Never heard of any loadable protocol outside
of tree.

Those loadable protocols that we have in tree (carp, divert) do
not look at ip_len.

-- 
Totus tuus, Glebius.