From owner-svn-ports-head@freebsd.org  Wed Jul 19 09:11:07 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F478C0AEA3;
 Wed, 19 Jul 2017 09:11:07 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from toco-domains.de (mail.toco-domains.de [176.9.39.170])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3855972427;
 Wed, 19 Jul 2017 09:11:06 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from [0.0.0.0] (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6])
 by toco-domains.de (Postfix) with ESMTPA id 628351AAF05C;
 Wed, 19 Jul 2017 11:10:53 +0200 (CEST)
Subject: Re: svn commit: r446066 - in head/databases: . postgresql-orafce
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201707171115.v6HBFqjc008876@repo.freebsd.org>
 <b727f21d-59ad-1375-4bd7-00d382de0537@FreeBSD.org>
From: Torsten Zuehlsdorff <tz@FreeBSD.org>
Message-ID: <528d514b-463a-c3c4-2f9c-a031dcabc667@FreeBSD.org>
Date: Wed, 19 Jul 2017 11:10:33 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <b727f21d-59ad-1375-4bd7-00d382de0537@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jul 2017 09:11:07 -0000

On 17.07.2017 16:45, Mathieu Arnold wrote:
> Le 17/07/2017 à 13:15, Torsten Zuehlsdorff a écrit :
>> +PLIST_FILES=	lib/postgresql/orafce.so \
>> +		%%PORTDOCS%%%%DOCSDIR%%/README.asciidoc \
>> +		share/postgresql/extension/orafce--3.2--3.3.sql \
>> +		share/postgresql/extension/orafce--3.3--3.4.sql \
>> +		share/postgresql/extension/orafce--3.4.sql \
>> +		share/postgresql/extension/orafce.control
> 
> 1) remove the README.asciidoc from there, and add PORTDOCS=README.asciidoc
> 2) you never use %%foo%% placeholders in PLIST_FILES.  The placeholders
> are necessary to carry variables from the Makefile to the plist file.
> In this case, you are in the Makefile, so you do not need to add one
> more level of indirection to use the placeholders.
> 
> If you were dead set against using PORTDOCS, you could use:
> 
> DOCS_PLIST_FILES= ${DOCSDIR}/README.asciidoc

Thank you for the explanation! I wasn't aware of this. Fixed in r446189.

Greetings,
Torsten