Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Mar 2012 08:50:13 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: kern/165271: commit references a PR
Message-ID:  <201203020850.q228oDcK053693@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/165271; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/165271: commit references a PR
Date: Fri,  2 Mar 2012 08:49:22 +0000 (UTC)

 Author: mav
 Date: Fri Mar  2 08:49:07 2012
 New Revision: 232380
 URL: http://svn.freebsd.org/changeset/base/232380
 
 Log:
   Fix names of some Marvell SATA chips. It looks like chips with proprietary
   interface supported by mvs(4) are 88SX, while AHCI-like chips are 88SE.
   
   PR:		kern/165271
   Submitted by:	Jia-Shiun Li <jiashiun@gmail.com>
   MFC after:	1 week
 
 Modified:
   head/share/man/man4/ahci.4
   head/share/man/man4/ata.4
   head/sys/dev/ahci/ahci.c
   head/sys/dev/ata/ata-pci.h
   head/sys/dev/ata/chipsets/ata-ahci.c
   head/sys/dev/ata/chipsets/ata-marvell.c
 
 Modified: head/share/man/man4/ahci.4
 ==============================================================================
 --- head/share/man/man4/ahci.4	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/share/man/man4/ahci.4	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -146,7 +146,7 @@ subclass 6 (SATA) and programming interf
  .Pp
  Also, in cooperation with atamarvell and atajmicron drivers of ata(4),
  it supports AHCI part of legacy-PATA + AHCI-SATA combined controllers,
 -such as JMicron JMB36x and Marvell 88SX61xx.
 +such as JMicron JMB36x and Marvell 88SE61xx.
  .Sh FILES
  .Bl -tag -width /dev/led/ahcich*.locate
  .It Pa /dev/led/ahcich*.act
 
 Modified: head/share/man/man4/ata.4
 ==============================================================================
 --- head/share/man/man4/ata.4	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/share/man/man4/ata.4	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -193,8 +193,8 @@ IT8211F, IT8212F, IT8213F.
  .It JMicron:
  JMB360, JMB361, JMB363, JMB365, JMB366, JMB368.
  .It Marvell
 -88SX5040, 88SX5041, 88SX5080, 88SX5081, 88SX6041, 88SX6042, 88SX6081, 88SX6101,
 -88SX6102, 88SX6111, 88SX6121, 88SX6141, 88SX6145, 88SX7042.
 +88SX5040, 88SX5041, 88SX5080, 88SX5081, 88SX6041, 88SX6042, 88SX6081, 88SE6101,
 +88SE6102, 88SE6111, 88SE6121, 88SE6141, 88SE6145, 88SX7042.
  .It National:
  SC1100.
  .It NetCell:
 
 Modified: head/sys/dev/ahci/ahci.c
 ==============================================================================
 --- head/sys/dev/ahci/ahci.c	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/sys/dev/ahci/ahci.c	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -186,13 +186,13 @@ static struct {
  	{0x2365197b, 0x00, "JMicron JMB365",	AHCI_Q_NOFORCE},
  	{0x2366197b, 0x00, "JMicron JMB366",	AHCI_Q_NOFORCE},
  	{0x2368197b, 0x00, "JMicron JMB368",	AHCI_Q_NOFORCE},
 -	{0x611111ab, 0x00, "Marvell 88SX6111",	AHCI_Q_NOFORCE | AHCI_Q_1CH |
 +	{0x611111ab, 0x00, "Marvell 88SE6111",	AHCI_Q_NOFORCE | AHCI_Q_1CH |
  	    AHCI_Q_EDGEIS},
 -	{0x612111ab, 0x00, "Marvell 88SX6121",	AHCI_Q_NOFORCE | AHCI_Q_2CH |
 +	{0x612111ab, 0x00, "Marvell 88SE6121",	AHCI_Q_NOFORCE | AHCI_Q_2CH |
  	    AHCI_Q_EDGEIS | AHCI_Q_NONCQ | AHCI_Q_NOCOUNT},
 -	{0x614111ab, 0x00, "Marvell 88SX6141",	AHCI_Q_NOFORCE | AHCI_Q_4CH |
 +	{0x614111ab, 0x00, "Marvell 88SE6141",	AHCI_Q_NOFORCE | AHCI_Q_4CH |
  	    AHCI_Q_EDGEIS | AHCI_Q_NONCQ | AHCI_Q_NOCOUNT},
 -	{0x614511ab, 0x00, "Marvell 88SX6145",	AHCI_Q_NOFORCE | AHCI_Q_4CH |
 +	{0x614511ab, 0x00, "Marvell 88SE6145",	AHCI_Q_NOFORCE | AHCI_Q_4CH |
  	    AHCI_Q_EDGEIS | AHCI_Q_NONCQ | AHCI_Q_NOCOUNT},
  	{0x91201b4b, 0x00, "Marvell 88SE912x",	AHCI_Q_EDGEIS|AHCI_Q_NOBSYRES},
  	{0x91231b4b, 0x11, "Marvell 88SE912x",	AHCI_Q_NOBSYRES|AHCI_Q_ALTSIG},
 
 Modified: head/sys/dev/ata/ata-pci.h
 ==============================================================================
 --- head/sys/dev/ata/ata-pci.h	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/sys/dev/ata/ata-pci.h	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -278,12 +278,12 @@ struct ata_pci_controller {
  #define ATA_M88SX6042           0x604211ab
  #define ATA_M88SX6081           0x608111ab
  #define ATA_M88SX7042           0x704211ab
 -#define ATA_M88SX6101           0x610111ab
 -#define ATA_M88SX6102           0x610211ab
 -#define ATA_M88SX6111           0x611111ab
 -#define ATA_M88SX6121           0x612111ab
 -#define ATA_M88SX6141           0x614111ab
 -#define ATA_M88SX6145           0x614511ab
 +#define ATA_M88SE6101           0x610111ab
 +#define ATA_M88SE6102           0x610211ab
 +#define ATA_M88SE6111           0x611111ab
 +#define ATA_M88SE6121           0x612111ab
 +#define ATA_M88SE6141           0x614111ab
 +#define ATA_M88SE6145           0x614511ab
  #define ATA_MARVELL2_ID         0x1b4b
  
  #define ATA_MICRON_ID           0x1042
 
 Modified: head/sys/dev/ata/chipsets/ata-ahci.c
 ==============================================================================
 --- head/sys/dev/ata/chipsets/ata-ahci.c	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/sys/dev/ata/chipsets/ata-ahci.c	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -180,12 +180,12 @@ ata_ahci_chipinit(device_t dev)
      ctlr->ichannels = ATA_INL(ctlr->r_res2, ATA_AHCI_PI);
      ctlr->channels = MAX(flsl(ctlr->ichannels),
  	    (ATA_INL(ctlr->r_res2, ATA_AHCI_CAP) & ATA_AHCI_CAP_NPMASK) + 1);
 -    if (pci_get_devid(dev) == ATA_M88SX6111)
 +    if (pci_get_devid(dev) == ATA_M88SE6111)
  	    ctlr->channels = 1;
 -    else if (pci_get_devid(dev) == ATA_M88SX6121)
 +    else if (pci_get_devid(dev) == ATA_M88SE6121)
  	    ctlr->channels = 2;
 -    else if (pci_get_devid(dev) == ATA_M88SX6141 ||
 -	pci_get_devid(dev) == ATA_M88SX6145)
 +    else if (pci_get_devid(dev) == ATA_M88SE6141 ||
 +	pci_get_devid(dev) == ATA_M88SE6145)
  	    ctlr->channels = 4;
  
      ctlr->reset = ata_ahci_reset;
 
 Modified: head/sys/dev/ata/chipsets/ata-marvell.c
 ==============================================================================
 --- head/sys/dev/ata/chipsets/ata-marvell.c	Fri Mar  2 07:23:28 2012	(r232379)
 +++ head/sys/dev/ata/chipsets/ata-marvell.c	Fri Mar  2 08:49:07 2012	(r232380)
 @@ -108,12 +108,12 @@ ata_marvell_probe(device_t dev)
       { ATA_M88SX6042, 0, 4, MV_6042, ATA_SA300, "88SX6042" },
       { ATA_M88SX6081, 0, 8, MV_60XX, ATA_SA300, "88SX6081" },
       { ATA_M88SX7042, 0, 4, MV_7042, ATA_SA300, "88SX7042" },
 -     { ATA_M88SX6101, 0, 0, MV_61XX, ATA_UDMA6, "88SX6101" },
 -     { ATA_M88SX6102, 0, 0, MV_61XX, ATA_UDMA6, "88SX6102" },
 -     { ATA_M88SX6111, 0, 1, MV_61XX, ATA_UDMA6, "88SX6111" },
 -     { ATA_M88SX6121, 0, 2, MV_61XX, ATA_UDMA6, "88SX6121" },
 -     { ATA_M88SX6141, 0, 4, MV_61XX, ATA_UDMA6, "88SX6141" },
 -     { ATA_M88SX6145, 0, 4, MV_61XX, ATA_UDMA6, "88SX6145" },
 +     { ATA_M88SE6101, 0, 0, MV_61XX, ATA_UDMA6, "88SE6101" },
 +     { ATA_M88SE6102, 0, 0, MV_61XX, ATA_UDMA6, "88SE6102" },
 +     { ATA_M88SE6111, 0, 1, MV_61XX, ATA_UDMA6, "88SE6111" },
 +     { ATA_M88SE6121, 0, 2, MV_61XX, ATA_UDMA6, "88SE6121" },
 +     { ATA_M88SE6141, 0, 4, MV_61XX, ATA_UDMA6, "88SE6141" },
 +     { ATA_M88SE6145, 0, 4, MV_61XX, ATA_UDMA6, "88SE6145" },
       { 0x91a41b4b,    0, 0, MV_91XX, ATA_UDMA6, "88SE912x" },
       { 0, 0, 0, 0, 0, 0}};
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203020850.q228oDcK053693>