From owner-cvs-all Sat Aug 26 12:57:17 2000 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [209.152.133.57]) by hub.freebsd.org (Postfix) with ESMTP id BB65537B422; Sat, 26 Aug 2000 12:57:13 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id MAA00794; Sat, 26 Aug 2000 12:56:55 -0700 (PDT) (envelope-from obrien) Date: Sat, 26 Aug 2000 12:56:55 -0700 From: "David O'Brien" To: Doug White Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c Message-ID: <20000826125655.A767@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200008260512.WAA65739@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from dwhite@resnet.uoregon.edu on Sat, Aug 26, 2000 at 12:11:59PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Aug 26, 2000 at 12:11:59PM -0700, Doug White wrote: > Um, isn't this a no-no? You're not supposed to re-style existing files; > you generated a 700-line diff for no functional change. Up to the maintainer. The style in the linux compat source is inconsistent. And if it makes the maintainers job easier or him happier, then that is suffient. Such a commit should be done separate from functionality changes though (as it was). -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message