Date: Sat, 24 Nov 2012 01:17:16 -0500 From: "Jason E. Hale" <jhale@freebsd.org> To: Dima Panov <fluffy@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307701 - head/graphics/vigra Message-ID: <23752824.Nt9BvllcTf@mocha.verizon.net> In-Reply-To: <201211240225.qAO2PdBV045963@svn.freebsd.org> References: <201211240225.qAO2PdBV045963@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, November 24, 2012 02:25:38 Dima Panov wrote: > Author: fluffy > Date: Sat Nov 24 02:25:38 2012 > New Revision: 307701 > URL: http://svnweb.freebsd.org/changeset/ports/307701 > > Log: > - Force to use gcc46+ if CC is not Clang. > > Feature safe: yes > > Modified: > head/graphics/vigra/Makefile > > Modified: head/graphics/vigra/Makefile > ============================================================================ > == --- head/graphics/vigra/Makefile Sat Nov 24 02:23:00 2012 (r307700) +++ > head/graphics/vigra/Makefile Sat Nov 24 02:25:38 2012 (r307701) @@ -56,6 > +56,12 @@ PLIST_SUB+= PYTHON="@comment " > > .include <bsd.port.pre.mk> > > +# Check for clang, else use gcc46+ > +CPP_check!= ${CPP} --version | tr -d '()' > +.if !${CPP_check:Mclang} > +USE_GCC= 4.6+ > +.endif > + I think it would be better to avoid the '!=' expansion and check for clang/clang++ with something like this: .if ${CC:T:Mclang} != "clang" && ${CXX:T:Mclang++} != "clang++" USE_GCC= 4.6+ .endif -- Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?23752824.Nt9BvllcTf>