Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Dec 2011 07:59:16 GMT
From:      Mikolaj Golub <trociny@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/163175: port: devel/lmdbg: Makefile tweaks
Message-ID:  <201112110759.pBB7xGkk071720@red.freebsd.org>
Resent-Message-ID: <201112110800.pBB80LH7090192@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         163175
>Category:       ports
>Synopsis:       port: devel/lmdbg: Makefile tweaks
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 11 08:00:20 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Mikolaj Golub
>Release:        
>Organization:
>Environment:
>Description:
* Tweaks suggested by Aleksey Cheusov (the author of lmdbg and mk-configure):

 - since version 0.19 of mk-configure there is no need in specifying installdirs in INSTALL_TARGET, so it can be removed and the default INSTALL_TARGET is used;

 - pass HAVE_HEADER.execinfo_h=0 to mkcmake via MKCMAKE_FLAGS rather than MKCMAKE_ENV.

* Tweaks suggested by portlint:

 - a newline at the end of distinfo;

 - a blank line between RUN_DEPENDS and USE_LDCONFIG.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -u devel/lmdbg.orig/Makefile devel/lmdbg/Makefile
--- devel/lmdbg.orig/Makefile	2011-12-11 00:12:04.000000000 +0200
+++ devel/lmdbg/Makefile	2011-12-11 09:35:31.000000000 +0200
@@ -17,12 +17,12 @@
 LIB_DEPENDS=	Judy:${PORTSDIR}/devel/judy
 RUN_DEPENDS=	runawk:${PORTSDIR}/lang/runawk \
 		${LOCALBASE}/bin/pipestatus:${PORTSDIR}/devel/pipestatus
+
 USE_LDCONFIG=	yes
 
 LICENSE=	MIT
 
 MKCMAKE?=	${LOCALBASE}/bin/mkcmake
-INSTALL_TARGET=	installdirs install
 
 PORTDOCS=	ChangeLog NEWS README TODO
 
@@ -31,13 +31,13 @@
 
 MKCMAKE_ENV+=	CPPFLAGS=-I${LOCALBASE}/include
 MKCMAKE_ENV+=	LDFLAGS=-L${LOCALBASE}/lib
-MKCMAKE_ENV+=	HAVE_HEADER.execinfo_h=0
+MKCMAKE_FLAGS+=	HAVE_HEADER.execinfo_h=0
 
 do-build:
-	${SETENV} ${MKCMAKE_ENV} ${MKCMAKE} -C ${WRKSRC}
+	${SETENV} ${MKCMAKE_ENV} ${MKCMAKE} ${MKCMAKE_FLAGS} -C ${WRKSRC}
 
 do-install:
-	${SETENV} ${MKCMAKE_ENV} ${MKCMAKE} -C ${WRKSRC} ${INSTALL_TARGET}
+	${SETENV} ${MKCMAKE_ENV} ${MKCMAKE} ${MKCMAKE_FLAGS} -C ${WRKSRC} ${INSTALL_TARGET}
 
 post-install:
 .if !defined(NOPORTDOCS)
diff -u devel/lmdbg.orig/distinfo devel/lmdbg/distinfo
--- devel/lmdbg.orig/distinfo	2011-12-11 00:12:04.000000000 +0200
+++ devel/lmdbg/distinfo	2011-12-11 09:13:44.000000000 +0200
@@ -1,2 +1,2 @@
 SHA256 (lmdbg-0.17.0.tar.gz) = 4dbd982a794f8a8b3c7732b4c6a7304a2e8f805ee7dcd98d30f588fb9051b30f
-SIZE (lmdbg-0.17.0.tar.gz) = 52225
\ No newline at end of file
+SIZE (lmdbg-0.17.0.tar.gz) = 52225


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112110759.pBB7xGkk071720>