From owner-cvs-all Thu Mar 7 4:27:30 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id D801837B405; Thu, 7 Mar 2002 04:27:24 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g27CPno66695; Thu, 7 Mar 2002 04:25:49 -0800 (PST) (envelope-from obrien) Date: Thu, 7 Mar 2002 04:21:45 -0800 From: "David O'Brien" To: Mark Murray Cc: Will Andrews , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307042145.B66608@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020307032014.B63863@dragon.nuxi.com> <200203071206.g27C6nRV009991@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203071206.g27C6nRV009991@grimreaper.grondar.org>; from mark@grondar.za on Thu, Mar 07, 2002 at 12:06:49PM +0000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Mar 07, 2002 at 12:06:49PM +0000, Mark Murray wrote: > > 2. please review the C idiom of short-circuit evaluation. > > I know this. See style(9) on complicated expressions. Please point out which section you are referring to. I glanced thru style(9) wondering if the if() style changes are mandated. Searching on "assignment" or "complicated" gave nothing. And the examples such as: if ((four = malloc(sizeof(struct foo))) == NULL) seem to approve the style. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message