Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 Mar 2023 07:52:35 GMT
From:      =?utf-8?Q?Roger=20Pau=20Monn=C3=A9?= <royger@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: e45c8ea31cd8 - main - xen/intr: merge parts of resume functionality into new function
Message-ID:  <202303290752.32T7qZr4052140@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The branch main has been updated by royger:

URL: https://cgit.FreeBSD.org/src/commit/?id=e45c8ea31cd89feda2b5b31bd623f4879602aec5

commit e45c8ea31cd89feda2b5b31bd623f4879602aec5
Author:     Elliott Mitchell <ehem+freebsd@m5p.com>
AuthorDate: 2021-06-01 00:55:12 +0000
Commit:     Roger Pau Monné <royger@FreeBSD.org>
CommitDate: 2023-03-29 07:51:44 +0000

    xen/intr: merge parts of resume functionality into new function
    
    The portions of xen_rebind_ipi() and xen_rebind_virq() were already
    near-identical.  While xen_rebind_ipi() should panic() on
    single-processor, still having the functionality to invoke seems
    harmless.
    
    Meanwhile much of the loop from xen_intr_resume() seemed to want to be
    closer to this same code.  This pushes related bits closer together.
    
    Reviewed by: royger
    Differential Revision: https://reviews.freebsd.org/D30598
---
 sys/x86/xen/xen_intr.c | 52 ++++++++++++++++++++++++++------------------------
 1 file changed, 27 insertions(+), 25 deletions(-)

diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c
index 39486f28c9c5..e2f23b4a5c6e 100644
--- a/sys/x86/xen/xen_intr.c
+++ b/sys/x86/xen/xen_intr.c
@@ -707,16 +707,6 @@ xen_rebind_ipi(struct xenisrc *isrc)
 		panic("unable to rebind xen IPI: %d", error);
 
 	isrc->xi_port = bind_ipi.port;
-	isrc->xi_cpu = 0;
-	xen_intr_port_to_isrc[bind_ipi.port] = isrc;
-
-	error = xen_intr_assign_cpu(&isrc->xi_intsrc,
-	                            cpu_apic_ids[cpu]);
-	if (error)
-		panic("unable to bind xen IPI to CPU#%d: %d",
-		      cpu, error);
-
-	evtchn_unmask_port(bind_ipi.port);
 #else
 	panic("Resume IPI event channel on UP");
 #endif
@@ -737,18 +727,39 @@ xen_rebind_virq(struct xenisrc *isrc)
 		panic("unable to rebind xen VIRQ#%d: %d", isrc->xi_virq, error);
 
 	isrc->xi_port = bind_virq.port;
-	isrc->xi_cpu = 0;
-	xen_intr_port_to_isrc[bind_virq.port] = isrc;
+}
+
+static void
+xen_intr_rebind_isrc(struct xenisrc *isrc)
+{
+#ifdef SMP
+	u_int cpu = isrc->xi_cpu;
+	int error;
+#endif
+
+	switch (isrc->xi_type) {
+	case EVTCHN_TYPE_IPI:
+		xen_rebind_ipi(isrc);
+		break;
+	case EVTCHN_TYPE_VIRQ:
+		xen_rebind_virq(isrc);
+		break;
+	default:
+		return;
+	}
+
+	xen_intr_port_to_isrc[isrc->xi_port] = isrc;
 
 #ifdef SMP
+	isrc->xi_cpu = 0;
 	error = xen_intr_assign_cpu(&isrc->xi_intsrc,
 	                            cpu_apic_ids[cpu]);
 	if (error)
-		panic("unable to bind xen VIRQ#%d to CPU#%d: %d",
-		      isrc->xi_virq, cpu, error);
+		panic("%s(): unable to rebind Xen channel %u to vCPU%u: %d",
+		    __func__, isrc->xi_port, cpu, error);
 #endif
 
-	evtchn_unmask_port(bind_virq.port);
+	evtchn_unmask_port(isrc->xi_port);
 }
 
 /**
@@ -789,16 +800,7 @@ xen_intr_resume(struct pic *unused, bool suspend_cancelled)
 		isrc = (struct xenisrc *)intr_lookup_source(vector);
 		if (isrc != NULL) {
 			isrc->xi_port = INVALID_EVTCHN;
-			switch (isrc->xi_type) {
-			case EVTCHN_TYPE_IPI:
-				xen_rebind_ipi(isrc);
-				break;
-			case EVTCHN_TYPE_VIRQ:
-				xen_rebind_virq(isrc);
-				break;
-			default:
-				break;
-			}
+			xen_intr_rebind_isrc(isrc);
 		}
 	}
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303290752.32T7qZr4052140>