From owner-freebsd-geom@FreeBSD.ORG  Thu Oct 23 15:18:48 2008
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A92DF1065675
	for <freebsd-geom@freebsd.org>; Thu, 23 Oct 2008 15:18:48 +0000 (UTC)
	(envelope-from marius@nuenneri.ch)
Received: from mail-gx0-f16.google.com (mail-gx0-f16.google.com
	[209.85.217.16])
	by mx1.freebsd.org (Postfix) with ESMTP id C863A8FC27
	for <freebsd-geom@freebsd.org>; Thu, 23 Oct 2008 15:18:46 +0000 (UTC)
	(envelope-from marius@nuenneri.ch)
Received: by gxk9 with SMTP id 9so62091gxk.13
	for <freebsd-geom@freebsd.org>; Thu, 23 Oct 2008 08:18:45 -0700 (PDT)
Received: by 10.115.89.1 with SMTP id r1mr753031wal.12.1224775123033;
	Thu, 23 Oct 2008 08:18:43 -0700 (PDT)
Received: by 10.115.89.3 with HTTP; Thu, 23 Oct 2008 08:18:42 -0700 (PDT)
Message-ID: <b649e5e0810230818n7a80033atb9be624d0f8f8398@mail.gmail.com>
Date: Thu, 23 Oct 2008 17:18:42 +0200
From: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" <marius@nuenneri.ch>
To: "Ivan Voras" <ivoras@freebsd.org>
In-Reply-To: <b649e5e0810230501g2b2e8ee0iaa66388ed767e69c@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <b649e5e0810230412u5a80ddb8p3955d5b052fa1896@mail.gmail.com>
	<gdpnsf$8s2$1@ger.gmane.org>
	<b649e5e0810230501g2b2e8ee0iaa66388ed767e69c@mail.gmail.com>
Cc: freebsd-geom@freebsd.org
Subject: Re: [PATCH] Teach geom_label to recognise gpt labels and uuids
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2008 15:18:48 -0000

On Thu, Oct 23, 2008 at 2:01 PM, Marius N=FCnnerich <marius@nuenneri.ch> wr=
ote:
> On Thu, Oct 23, 2008 at 1:41 PM, Ivan Voras <ivoras@freebsd.org> wrote:
>> Marius N=FCnnerich wrote:
>>> Hi all,
>>>
>>> I wrote the following patch for geom_label:
>>> http://nuenneri.ch/freebsd/geom_label.patch
>>>
>>> What do you think about it? I would love to hear about some tests.
>>
>> Do you think it's wise to have two separate directories: /dev/gpt and
>> /dev/gpt_uuid? I don't think anyone will mistake the UUID from the label
>> if it's in the same directory. Also, if I remember correctly how GPT
>> works, UUID is always present but the label is optional?
>
> The label can only be 18 characters long and a uuid is always longer
> than that, so that shouldn't be a problem. Actually it's just an
> implementation detail because I couldn't add two /dev entries in one
> taste. I will think about how I could create both entries in one
> directory (if the label is set).

Ok, I updated the patch. It's now just /dev/gpt. I think I'll collapse
the two files into one.

Thanks for your feedback so far.