Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Dec 2011 20:50:16 +0100
From:      Harti Brandt <hartmut.brandt@dlr.de>
To:        Ben Kaduk <minimarmot@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ulrich Spoerlein <uqs@freebsd.org>
Subject:   Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp...
Message-ID:  <20111230204653.Y31442@beagle.kn.op.dlr.de>
In-Reply-To: <CAK2BMK6p3VJXezt%2Bpa7-0MbP4=Uv79i=D=cxmDrpAwUK2Mw2vQ@mail.gmail.com>
References:  <201112301058.pBUAwFsw010478@svn.freebsd.org> <CAK2BMK6p3VJXezt%2Bpa7-0MbP4=Uv79i=D=cxmDrpAwUK2Mw2vQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--1964543108-470614106-1325274616=:31442
Content-Type: text/plain; charset="koi8-r"
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 30 Dec 2011, Ben Kaduk wrote:

BK>On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <uqs@freebsd.org> wrot=
e:
BK>> Author: uqs
BK>> Date: Fri Dec 30 10:58:14 2011
BK>> New Revision: 228990
BK>> URL: http://svn.freebsd.org/changeset/base/228990
BK>>
BK>> Log:
BK>> =9ASpelling fixes for usr.sbin/
BK>>

[snip]

BK>> Modified: head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.=
txt
BK>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
BK>> --- head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.txt =
=9A =9A Fri Dec 30 10:45:00 2011 =9A =9A =9A =9A(r228989)
BK>> +++ head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.txt =
=9A =9A Fri Dec 30 10:58:14 2011 =9A =9A =9A =9A(r228990)
BK>> @@ -82,8 +82,8 @@ WlanMgmtReasonCode ::=3D TEXTUAL-CONVENTIO
BK>> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9AassociationLeave(8),
BK>> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9AassociationNotAuthenticated(9),
BK>> =9A-- XXX: TODO - FIXME
BK>> - =9A =9A =9A =9A =9A =9A =9A =9A =9A dissasocPwrcapBad(10),
BK>> - =9A =9A =9A =9A =9A =9A =9A =9A =9A dissasocSuperchanBad(11),
BK>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A disassocPwrcapBad(10),
BK>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A disassocSuperchanBad(11),
BK>
BK>This file looks like it might be intended to be machine-readable -- I
BK>would worry about changing it without test/review.
BK>Perhaps this spelling "error" is even the reason for the XXX comment abo=
ve.

Absolutely. If there is a spelling error in an SNMP MIB outside comments=20
or description strings it must stay there. Otherwise applications reading=
=20
that file will break.

This is also true for the corresponding .def file.

harti
--1964543108-470614106-1325274616=:31442--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111230204653.Y31442>