Date: Thu, 17 Apr 1997 13:20:42 -0700 From: Amancio Hasty <hasty@rah.star-gate.com> To: Steve Passe <smp@csn.net> Cc: multimedia@freebsd.org Subject: Re: Fxtv 0.4 Message-ID: <199704172020.NAA00528@rah.star-gate.com> In-Reply-To: Your message of "Thu, 17 Apr 1997 11:00:16 MDT." <199704171700.LAA21089@Ilsa.StevesCafe.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Steve, Good point, for sure the code needs a little bit more comments. All in all I am very happy with the way that the driver has turned out. >From The Desk Of Steve Passe : > Hi, > > >In the same routine there is this comment: > > > >/* FIXME: why set colorbars for 1 instant ??? */ > > bt848->color_ctl = BT848_COLOR_CTL_COLOR_BARS; > >/* FIXME: undone 4 lines later, why bother ??? */ > > bt848->color_ctl = BT848_COLOR_CTL_GAMMA; > > > >Careful here because some of this stuff was written after I read > >Brooktree's DOS demo. Some of these chipsets are cranky and yes > >we can experiment by taking the lines out. > > the "FIXME" protocal is mine, while doing my cleanup passes I added those > lines wherever I saw something that needed attention. In many cases > it may be that the code is valid, but that it is something arcane > (cranky chipset really wants that bit set for no apparrent reason!) Oh Steve, some of this PC chipset manufacturers don't do a good job at quality assurance and whenever they can they have soft work arounds over hardware fixes. Chips like the Bt848 are complicated and is not feasible to fully test the chip. > so in this case the "FIX" would be a comment that explains why its there. > This way someone like me can come along and not wonder "what the h*** is that > there for???". Remember that this driver will have a long lifetime, and peop le > may be dealing it long after we're not available/have forgotten ourselves > the little details. Point well taken... Regards, Amancio
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704172020.NAA00528>