From owner-svn-src-head@freebsd.org Wed Mar 14 22:56:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4EB07F4FF9C for ; Wed, 14 Mar 2018 22:56:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3A6B7B8A1 for ; Wed, 14 Mar 2018 22:56:37 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm0-x22b.google.com with SMTP id i194so7041921wmg.1 for ; Wed, 14 Mar 2018 15:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+G2LKilQWpU4xzD85C+CWtGPeZGoTIcECSNak5eGcVU=; b=EgWhiCBhjDc++HvrOH1+2D1XjQhHU5bBKEP8ZWJyUyk6tbBR9DK58a+cGnXxR+1anS KjjQ5b2jTFdHwx9CRU+s5EiOHPLOwhVwKfRvgWS8XIyHvbZKh7rLGOmqCEGEfox/W1Xw xpQWRZRd9s3G0tBl9M8Rj0J0PdDWA+qugajwPXH/cW2rmuqUrWaGvgBbCZ/29WYHx4WU 2atIIfnMExhRnhJ+0YUZsIlEy6Kfwh7i6RR331csHFDCdqWC3Ranou2sTGsCHu45MMCl /UOAq51UxmSOX0KuAun1RQTl4PqoskhxuVMXIdaocNsv5uYw4eKyMjgBHUnH7yT6XmoT /R1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+G2LKilQWpU4xzD85C+CWtGPeZGoTIcECSNak5eGcVU=; b=Oezoy6NBd1HvR+r4DkPOYg9VbmssgEh5tTOCFqldZTjXLV9Xp4o0AyrAAE1Tmj3Ntd yhhRvZd2pj1YKNuLpSB+bu/QvDk544zWtI59oJ46P6bxPZ4+m8N6dKpio0hRK6JRi1O1 YKYr3SZbfzBxuebBHwoJnBmpN9vL25AYZE0Um8+lnuMgCrM349W3TSSeVzcVWj3rIOeP zNYvLbdN7eot1+IaPZq6TMnAQi8cM2fjMJI7neVeNjyV3hxoU6CCV76gBEAnYL8qzaaX vRhBVNdvU25pL4Z9mccnKWcA3lX96/J8zUXJUIhp52TALWoxhsdz39/lFxC0NhZOqCjt UFVg== X-Gm-Message-State: AElRT7FB5v7W55oD266JElJxBbqiwMW8sqK7lI+jCwtPQEy1pwF2Kd1f pXEE7G0mjk4g4Pqqj4L4EsjPjg== X-Google-Smtp-Source: AG47ELv4jDzf6G/Q8XIZqAy1sDnAvEyWZ0+F/m7i8tiEuu3uG8lpCIqLJwjgmI3/vbB4y01PBDATrw== X-Received: by 10.28.137.147 with SMTP id l141mr2787388wmd.141.1521068196537; Wed, 14 Mar 2018 15:56:36 -0700 (PDT) Received: from mutt-hbsd ([5.254.112.154]) by smtp.gmail.com with ESMTPSA id z39sm5490694wrz.19.2018.03.14.15.56.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 15:56:35 -0700 (PDT) Date: Wed, 14 Mar 2018 18:56:23 -0400 From: Shawn Webb To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ye3dpcyzgfytrpzo" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20171215 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 22:56:38 -0000 --ye3dpcyzgfytrpzo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb > wrote: >=20 > > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > > Author: asomers > > > Date: Sun Feb 25 14:29:43 2018 > > > New Revision: 329984 > > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > > > Log: > > > Don't declare __assfail as static > > > > > > It gets called by dmu_buf_init_user, which is inline but not static. > > So it > > > needs global linkage itself. > > > > > > Reported by: GCC-6 > > > MFC after: 17 days > > > X-MFC-With: 329722 > > > > > > > Hey Alan, > > > > This commit breaks compiling world with ASAN. > > > > Some applications, like zfs, will fail with this error: > > > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > > > Thanks, > > >=20 > How does one build world with ASAN ? HardenedBSD has a feature branch in its playground repo for ASAN-ified world. We introduced two new MK_* toggles: MK_ASAN and MK_ASAN_RECOVER. MK_ASAN is self-explanitory. MK_ASAN_RECOVER tells the sanitizer framework to let the application continue running instead of abort execution. Here's where the magic gets set: https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/current= /asan/share/mk/bsd.prog.mk#L125-L134 Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --ye3dpcyzgfytrpzo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlqpqJcACgkQaoRlj1JF bu64kw//ZnaTKF5HLdKL0M8/lDw/6dPnkHE9y8hBIyl24jWJUeXrv/7qCbBlRvuf I3x3o1LO8EVvyPWJYtnAXOvnn1odFSZ6RpnOvM6QZHEvW3aOwhXC6xjRMVCxTdoa R30NbCyly76ZOghcXGZoZdCY/0c6cUdVxgiXqPDca+dVQRZhLMs0nqHKazewiiUE +u+f8w3R0SZcAWYcctYfrMSIHyi/7z4Nhe5uz99Kc8MsVrdTw47FARsApod35E0F H7srtVsLclK34vlgCWW5wjTXaedto6CMoYAB+PiINQ67c3KDdkOOkJhNVw5koVir nr4uwmqEHkCDmLOr0A/w1BpekLib7PGlKYiK+T6PqfFbRqXfrulJeLjC6ci/MYOi V6YG8yhVrd/pisLvMVemquDexP/FJG3/1B8H/H14wrGDDqSg1i4F+cPwqXtfy0NI u3Xg26nv/qK/ydXcHOnFadAPytFxVl+5k+ijP+kWwyfjAk2G4q/R88Uz6zWAmbI+ xjmXBuMG4aNvjaTnb5gfLphRof9EcyrAGF9CAyYQBJr/asqVZIDhI/LCmonnlJvl j0rJ1RzJPioRFPCCpZ7ePlRhBCO7cPIiwQrzUE6rTEpMPu9r8hybvoK35eALab1r PJaPtrJjysTM11GKkX6HjvaKE5RToiX6Rzu7BWUf1wMweBuk9Fg= =SzXb -----END PGP SIGNATURE----- --ye3dpcyzgfytrpzo--