Date: Fri, 23 Nov 2012 09:31:18 GMT From: Matt Smith <matt@xtaz.co.uk> To: freebsd-gnats-submit@FreeBSD.org Subject: conf/173857: Mistake in newsyslog.conf Message-ID: <201211230931.qAN9VI67007677@red.freebsd.org> Resent-Message-ID: <201211230940.qAN9e099056090@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173857 >Category: conf >Synopsis: Mistake in newsyslog.conf >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 23 09:40:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Matt Smith >Release: 9.1-RC3 >Organization: >Environment: FreeBSD tao.xtaz.co.uk 9.1-RC3 FreeBSD 9.1-RC3 #0 r242431M: Thu Nov 1 17:49:06 GMT 2012 root@tao.xtaz.co.uk:/usr/obj/usr/src/sys/TAO amd64 >Description: Discussed in forum here: http://forums.freebsd.org/showthread.php?t=35910 I believe there is a mistake in the /etc/newsyslog.conf. The line for rotating the weekly.log has a 1 in the size field where I believe this should be a *. This results in the reason for the log rotation always being because size <1K whereas because it's a log that's designed to be rotated weekly shouldn't this be based on the when clause rather than the size as the daily and monthly ones are? I apologise if this is done intentionally for some reason, but it seems odd to me and somebody on the forum agreed and so I have filed a PR. >How-To-Repeat: Enable the weekly.log in periodic.conf and observe when it gets rotated and the reason for the rotation given at the top of the log file. >Fix: Change the 1 under the size field for the weekly.log to a * Patch attached with submission follows: --- newsyslog.conf.old 2012-11-23 09:28:33.000000000 +0000 +++ newsyslog.conf 2012-11-23 09:28:42.000000000 +0000 @@ -34,5 +34,5 @@ /var/log/security 600 10 100 * JC /var/log/sendmail.st 640 10 * 168 B /var/log/utx.log 644 3 * @01T05 B -/var/log/weekly.log 640 5 1 $W6D0 JN +/var/log/weekly.log 640 5 * $W6D0 JN /var/log/xferlog 600 7 100 * JC >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211230931.qAN9VI67007677>