Date: Tue, 16 Jul 2024 09:59:00 +0200 From: Zsolt Udvari <uzsolt@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5 Message-ID: <ZpYoRPn05oiLS3cB@bsd-zsolt> In-Reply-To: <ZpYgBVxpkjc1w4Rb@FreeBSD.org> References: <202407131836.46DIaqMZ075082@gitrepo.freebsd.org> <ZpYgBVxpkjc1w4Rb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 16, 2024 at 07:23:49AM +0000, Alexey Dokuchaev wrote: > On Sat, Jul 13, 2024 at 06:36:52PM +0000, Zsolt Udvari wrote: > > commit d6a461ce6716be61682e196cd624903be0557e50 > > > > games/lolcat: update to 1.5 > > Pet portfmt while I'm here. > > ... > > @@ -19,7 +19,8 @@ CFLAGS+= -lm > > > > CONFLICTS_INSTALL= filters > > > > -PLIST_FILES= bin/censor bin/lolcat > > +PLIST_FILES= bin/censor \ > > + bin/lolcat > > I've seen these one-word-per-line splits before, presumably coming > from this portfmt thingy, and don't quite see the benefit in this > case for example, when words and lines are short. While I think > I understand the general rationale behind this, it often make the > Makefile actually *less* readable and longer, eating precious > vertical space. Thanks for comment. I understand what you say, but I don't know which version is better. _For me_ it's more readable this version because it's similar to pkg-plist file (one-word-per-line). Maybe should create a rule (as a coding style) and add to Porter's Handbook. Cheers, Zsolt Ps. I would avoid PLIST_FILES and use only pkg-plist file. One port uses PLIST_FILES another uses pkg-plist, it's a little confusing for me.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZpYoRPn05oiLS3cB>