From owner-svn-src-all@freebsd.org Tue Jun 16 17:12:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF422344A35; Tue, 16 Jun 2020 17:12:49 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49mZX14HxDz4PSG; Tue, 16 Jun 2020 17:12:49 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.5] (unknown [181.52.72.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id 0A8A713F3C; Tue, 16 Jun 2020 17:12:48 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: svn commit: r362217 - head/stand/common To: Ian Lepore , Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006160705.05G753T4057972@repo.freebsd.org> <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Tue, 16 Jun 2020 12:12:49 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 17:12:49 -0000 On 16/06/2020 12:01, Ian Lepore wrote: > On Tue, 2020-06-16 at 07:05 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Tue Jun 16 07:05:03 2020 >> New Revision: 362217 >> URL: https://svnweb.freebsd.org/changeset/base/362217 >> >> Log: >> loader: variable i is unused without MBR/GPT support built in >> >> Because i is only used as index in for loop, declare it in for >> statement. >> > As much as I prefer doing it this way, style(9) doesn't allow for > variable declarations inside a for() statement (or even inside a local > block, which is just too 1980s for me, but it is still our standard). Perhaps style(9) needs updating? I think KNF is mandatory for kernel code only, and is only suggested for userland. Pedro.