From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 25 17:36:11 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EAB537B412; Tue, 25 Mar 2003 17:36:11 -0800 (PST) Received: from scl8owa02.int.exodus.net (scl8out02.exodus.net [66.35.230.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F1CB4404B; Tue, 25 Mar 2003 17:29:04 -0800 (PST) (envelope-from Maksim.Yevmenkin@cw.com) Received: from scl8owa01.int.exodus.net ([66.35.230.241]) by scl8owa02.int.exodus.net with Microsoft SMTPSVC(5.0.2195.5329); Tue, 25 Mar 2003 17:28:58 -0800 Received: from exodus.net ([165.193.27.35]) by scl8owa01.int.exodus.net over TLS secured channel with Microsoft SMTPSVC(5.0.2195.5329); Tue, 25 Mar 2003 17:28:58 -0800 Message-ID: <3E81018F.70805@exodus.net> Date: Tue, 25 Mar 2003 17:25:35 -0800 From: Maksim Yevmenkin User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.1) Gecko/20021126 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Brian Somers References: <45258A4365C6B24A9832BFE224837D552B1283@sjdcex01.int.exodus.net> <3E3ED4DF.7090904@exodus.net> <3E3EDE11.192ABC3F@mindspring.com> <3E3EF111.5050401@exodus.net> <20030326011226.051dbae9.brian@Awfulhak.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Mar 2003 01:28:58.0398 (UTC) FILETIME=[12CD23E0:01C2F337] X-Spam-Status: No, hits=-15.6 required=5.0 tests=QUOTED_EMAIL_TEXT,REFERENCES,USER_AGENT_MOZILLA_UA autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: hackers@FreeBSD.ORG cc: brian@FreeBSD.ORG cc: questions@FreeBSD.ORG Subject: Re: [PATCH2] PPP in -direct mode does not execute any chat scripts X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2003 01:36:23 -0000 X-List-Received-Date: Wed, 26 Mar 2003 01:36:23 -0000 Hello Brian, > Yes, this looks fine, although I think this shows that the -direct > description is wrong. Perhaps this is more appropriate: > > -direct > This is used for communicating over an already established connection, > usually when receiving incoming connections accepted by getty(8). ppp > ignores the ``set device'' line and uses descriptor 0 as the link. ppp > will ignore any configured chat scripts unless the ``force-scripts'' > option has been enabled. > > If callback.... > > Do you agree with this description ? If so, I'll go ahead and commit the yes, this is more accurate description. i missed it. > changes. Just to be picky, I'll re-sort the OPT_ variables too :*P no problem :) > And thanks for the patches. thank you for reviewing them :) max > On Mon, 03 Feb 2003 14:45:37 -0800, Maksim Yevmenkin wrote: > >>Dear Brian and Hackers, >> >>Please find updated proposed version of the patch. As suggested by >>Warner option has been renamed to 'force-sripts' and now works for >>both 'direct' and 'dedicated' modes. Also as suggested by Terry the >>man page has been updated to document side effect of 'direct'. >> >>-direct >> This is used for receiving incoming connections. ppp ignores the >> ``set device'' line and uses descriptor 0 as the link. ppp will >> never use any configured chat scripts unless ``force-scripts'' >> option has been enabled. >> >> If callback is configured, ppp will use the ``set device'' infor- >> mation when dialing back. >> >>-dedicated >> This option is designed for machines connected with a dedicated >> wire. ppp will always keep the device open and will never use >> any configured chat scripts unless ``force-scripts'' option has >> been enabled. >> >>force-scripts >> Default: Disabled. Forces execution of the configured chat >> scripts in direct and dedicated modes. >> >> >>>>Please find attached patch that adds new option to the PPP. >>>> >>>>run-scripts-in-direct-mode >>>> Default: Disabled. This allows to run chat scripts in >>>> direct mode. >>>> >>>>did i miss anything? objections? comments? reviews? >>> >>> >>>First comment: run it past Brian Somers ; it's >>>his baby, and he's the active maintainer. >> >>I have sent him e-mail. >> >> >>>Rest of comments: >>> >>>Actually, why doesn't "-direct" allow a chat script by default? >>>The man page doesn't document that as a side-effect of "-direct", >>>only of "-dedicated", but it's been there since the import. >>> >>>Should this really be a "negotiate" section command, rather than >>>just a command or a "set" command? >>> >>>Also, there are only two other commands even have a "-" in them, >>>and both of them only have one (just seems a little long, compared >>>to, say, "rsid" or "direct-with-script", or even "force-script"). >>> >>>Personal preference: don't make it conditional on "-direct", let >>>it also work with "-dedicated", and call it "force-script" or >>>something, instead. >> >>done >> >> >>>The man page should be updated -- including the undocumented >>>side-effect of "-direct" disabling scripts). >> >>done >> >>thanks >>max >> > > >