From nobody Sat Oct 16 11:29:34 2021 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 288541804372 for ; Sat, 16 Oct 2021 11:29:44 +0000 (UTC) (envelope-from felix@palmen-it.de) Received: from stef.palmen-it.de (stef.palmen-it.de [IPv6:2001:470:1f0b:bbb:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HWgsL5xbBz4VP4 for ; Sat, 16 Oct 2021 11:29:42 +0000 (UTC) (envelope-from felix@palmen-it.de) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=palmen-it.de; s=20200414; h=Content-Type:MIME-Version:Message-ID:Subject:To :From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=epfhl16Mcl9vICJIEfWTttEdEuCyfm7H6OMcm0T/5YA=; b=kPgZjGE8r40LnvAPM/1GaZJPso e5jbBoN2mOUBSvtsjHUhw200e90CMSf+HKULs+JJYwvLmTw7PIlzkp38XMTsd9xK+BATL27C7B6YD eHuh6PrSJe0Gh5Gc0FQ/IaB//kyrE9aJgGM/LfDBEcwH6bT+Dc9RNkt9OheULEXkLPkT/O0MkKa6/ tpMQlL398APSSyQw+AnSx+Wv5NIMTtkCsW6/RGvXl/XZdL78NozwGdq4+KLSPId3EaFOPc/0lxEIC 52p2L3sShxQE7dNBjVwm08Oqo25y6y1o2Ab+yxbduJeNTYuPKj3aiAdAFLvlwPMJbN2HFs39fbKwV D2LTdC4w==; Received: from [192.168.71.101] (helo=mail.home.palmen-it.de) by stef.palmen-it.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mbhsd-003AUI-5E for freebsd-ports@FreeBSD.org; Sat, 16 Oct 2021 13:29:35 +0200 Received: from nexus.home.palmen-it.de ([192.168.99.2]) by mail.home.palmen-it.de with esmtpsa (TLS1.3) tls TLS_CHACHA20_POLY1305_SHA256 (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1mbhsc-0004l7-T0 for freebsd-ports@FreeBSD.org; Sat, 16 Oct 2021 11:29:34 +0000 Date: Sat, 16 Oct 2021 13:29:34 +0200 From: Felix Palmen To: freebsd-ports@FreeBSD.org Subject: About GIT and committing submissions Message-ID: <20211016112934.fnuderd67aprqjyb@nexus.home.palmen-it.de> Mail-Followup-To: freebsd-ports@FreeBSD.org X-Face: /1K@t"h.}e~pR@]c7HorQ!T`F^RJCa'BCr#e>IKA{>C/9OTGB4|xh"y2{?1Z5M i2w"AH^pN_LlHR^{+f',_Np~;.B;!M/bL}*qk]p5*r7F5vW};{:@4u5S?T&f0$7BJ-71Q5SV]:v$`5 A0[DZ:=?S52x8HJ~5@^P_\T@MsjG{R( Organization: palmen-it.de List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ineobxab2s6fetw6" Content-Disposition: inline User-Agent: NeoMutt/20210205 X-Rspamd-Queue-Id: 4HWgsL5xbBz4VP4 X-Spamd-Bar: -------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=palmen-it.de header.s=20200414 header.b=kPgZjGE8; dmarc=pass (policy=none) header.from=palmen-it.de; spf=pass (mx1.freebsd.org: domain of felix@palmen-it.de designates 2001:470:1f0b:bbb:1::1 as permitted sender) smtp.mailfrom=felix@palmen-it.de X-Spamd-Result: default: False [-8.74 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[palmen-it.de:s=20200414]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[palmen-it.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:1f0b:bbb:1::1]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[2001:470:1f0b:bbb:1::1:from]; DKIM_TRACE(0.00)[palmen-it.de:+]; DMARC_POLICY_ALLOW(-0.50)[palmen-it.de,none]; NEURAL_HAM_SHORT(-0.94)[-0.941]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --ineobxab2s6fetw6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi all, since the transition to GIT, there's a way to have author information of a commit in the VCS' own metadata, so the commit message metadata field 'Submitted by:' shouldn't be used any more. But in practice, I see a nice mixture of * Using GIT's --author info * Using 'Submitted by:' * Even using 'Reported by:' in combination with 'PR:' In order to make this more consistent, I'd suggest a few additional guidelines: * For contributors: - As the preferred format for submissions, use 'git format-patch'. Of course, a plain patch is still ok, and for complex submissions, taking them to phab is still preferred. - If you want to submit a series of commits that isn't complex enough for phab, just concatenate the files created by 'git format-patch'. * For committers: - If the submission is in 'git format-patch' format, use 'git am' to apply it and, if necessary, edit the commit message(s) with 'git commit --amend'. - Otherwise, use the '--author' flag to 'git commit' when committing the change. BTW, shouldn't submissions in shar format be removed from the porter's handbook entirely? I personally think they're cumbersome for both the contributor and the committer. So, what do you think? BR, Felix --=20 Dipl.-Inform. Felix Palmen ,.//.......... {web} http://palmen-it.de {jabber} [see email] ,//palmen-it.de {pgp public key} http://palmen-it.de/pub.txt // """"""""""" {pgp fingerprint} A891 3D55 5F2E 3A74 3965 B997 3EF2 8B0A BC02 DA2A --ineobxab2s6fetw6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEqJE9VV8uOnQ5ZbmXPvKLCrwC2ioFAmFqt5YACgkQPvKLCrwC 2irS+gf/bNwKa34g6Z153IVDqV94HGx9VS7v+E2XrpJYOSiUsHc19UPVdBRccLJU J6lvcst633QRnD0NiSLltlWkTQW2QB7ncPgmio0ZYS4lrzocKOulk1vxfRi/xuc0 GNMV/1itMY0Jl1CTl7i+mwnyqLNtPG3/W3Hl4pSk9m/MautkM3tuEEXMcrtNorRn t8bWCz26p5YKzKTHiZ9gfwYi/gF9EPXkiN9DnEHVr9dIui37LnTrTEYNmR6or8Dw bWEEon0HDPEK1ZnQ3yM0gbDOX5cKQlM4VRIsIcfEL9tg/O/ATR1JK8FpK/QmXlkJ MIr/PFHbk1AbwsdMOvNl7xyKJWj7yQ== =KD1l -----END PGP SIGNATURE----- --ineobxab2s6fetw6--