From owner-freebsd-ports@freebsd.org Mon Mar 22 17:32:41 2021 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 015B05B643C for ; Mon, 22 Mar 2021 17:32:41 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F41m86fG5z4WHr; Mon, 22 Mar 2021 17:32:40 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id C1C82C20A; Mon, 22 Mar 2021 17:32:40 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58:0:905a:1b8c:250a:d4bd] (unknown [IPv6:2001:470:7a58:0:905a:1b8c:250a:d4bd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 7B38231944; Mon, 22 Mar 2021 18:32:38 +0100 (CET) From: Dimitry Andric Message-Id: <829C6E3C-12B3-44FC-8B18-D3F0ACA87B57@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_E3C40213-F80A-418E-9C9B-1BA396F3757B"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: TCL and Unicode Date: Mon, 22 Mar 2021 18:32:29 +0100 In-Reply-To: <20210322134003.hhdmq6ljxun4tsyn@mutt-hbsd> Cc: freebsd-ports@freebsd.org To: Shawn Webb References: <20210322134003.hhdmq6ljxun4tsyn@mutt-hbsd> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 17:32:41 -0000 --Apple-Mail=_E3C40213-F80A-418E-9C9B-1BA396F3757B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 22 Mar 2021, at 14:40, Shawn Webb wrote: >=20 > I'm tracking down a regression in ports regarding TCL and unicode. The > primary victim of the problem is databases/sqlite3. Note that I use > freebsd-ports on github as my upstream, so I'll be using git commit > hashes from that repo. >=20 > The sqlite3 build failure can be seen at [1]. >=20 > If I revert commit 787aad81fc79d441fb0c9a750e6e33b6c0ea7ac6, sqlite3 > builds fine. I noticed a few key changes from that commit: >=20 > The build of sqlite3 depends on TCL: instead of using the distfile > that has the autoconf artifacts pre-generated, the distfile without > the autoconf artifacts is used (changing from > sqlite-autoconf-3340100.tar.gz to sqlite-src-3340100.zip). This > means that the TCL-based autoconf artifacts must be generated > locally. At least, partially. It seems that the only part of the > build that depends on TCL is the sqlite3_analyzer. >=20 > Admittedly, this change is somewhat confusing to me. I'm having > somewhat of a hard time knowing whether it's TCL or sqlite3 itself > as the main culprit. >=20 > Any guidance is appreciated. >=20 > [1]: = http://ci-08.md.hardenedbsd.org/data/hardenedbsd-current_amd64-local/2021-= 03-21_13h53m43s/logs/errors/sqlite3-3.34.1,1.log Hi Shawn, It builds fine for me locally on 14.0-CURRENT (as of ~2 days ago), and indeed the sqlite3.c file is now dynamically generated by tcl. In your CI failure case, it looks like something is inserting blobs of zero bytes into the resulting file, though? So either the file system is going bad, or tcl is outputting nonsense, for some reason. At least, I think you'll have to do some investigations in that direction... -Dimitry --Apple-Mail=_E3C40213-F80A-418E-9C9B-1BA396F3757B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iFwEARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYFjUrQAKCRCwXqMKLiCW o32AAJjCwpY3HvoYpHk0hFybBMPdqucUAKDoBNwChFWbSt6uibgyf+xMzgYIwQ== =DMW8 -----END PGP SIGNATURE----- --Apple-Mail=_E3C40213-F80A-418E-9C9B-1BA396F3757B--